From commits-return-12704-archive-asf-public=cust-asf.ponee.io@sentry.apache.org Thu May 31 05:32:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7A5EE18067C for ; Thu, 31 May 2018 05:32:03 +0200 (CEST) Received: (qmail 38469 invoked by uid 500); 31 May 2018 03:32:02 -0000 Mailing-List: contact commits-help@sentry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.apache.org Delivered-To: mailing list commits@sentry.apache.org Received: (qmail 34651 invoked by uid 99); 31 May 2018 03:31:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 May 2018 03:31:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AB476E118F; Thu, 31 May 2018 03:31:40 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: spena@apache.org To: commits@sentry.apache.org Date: Thu, 31 May 2018 03:32:41 -0000 Message-Id: In-Reply-To: <5efebc2704cd43a891f304274777fee8@git.apache.org> References: <5efebc2704cd43a891f304274777fee8@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [63/86] sentry git commit: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db (Anthony Young-Garner, reviewed by Sergio Pena, Steve Moist, Na Li) http://git-wip-us.apache.org/repos/asf/sentry/blob/7db84b2f/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java ---------------------------------------------------------------------- diff --git a/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java new file mode 100644 index 0000000..c23683f --- /dev/null +++ b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java @@ -0,0 +1,1239 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.sentry.api.service.thrift; + +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.TimeoutException; +import java.util.regex.Pattern; + +import org.apache.commons.lang.StringUtils; +import org.apache.hadoop.conf.Configuration; +import org.apache.sentry.api.common.ThriftConstants; +import org.apache.sentry.core.common.exception.SentryUserException; +import org.apache.sentry.core.common.exception.SentrySiteConfigurationException; +import org.apache.sentry.core.model.db.AccessConstants; +import org.apache.sentry.provider.common.GroupMappingService; +import org.apache.sentry.core.common.utils.PolicyFileConstants; +import org.apache.sentry.core.common.exception.SentryGroupNotFoundException; +import org.apache.sentry.core.common.exception.SentryAccessDeniedException; +import org.apache.sentry.core.common.exception.SentryAlreadyExistsException; +import org.apache.sentry.core.common.exception.SentryInvalidInputException; +import org.apache.sentry.core.common.exception.SentryNoSuchObjectException; +import org.apache.sentry.provider.db.SentryPolicyStorePlugin; +import org.apache.sentry.provider.db.SentryPolicyStorePlugin.SentryPluginException; +import org.apache.sentry.core.common.exception.SentryThriftAPIMismatchException; +import org.apache.sentry.provider.db.log.entity.JsonLogEntity; +import org.apache.sentry.provider.db.log.entity.JsonLogEntityFactory; +import org.apache.sentry.provider.db.log.util.Constants; +import org.apache.sentry.provider.db.service.persistent.SentryStore; +import org.apache.sentry.core.common.utils.PolicyStoreConstants.PolicyStoreServerConfig; +import org.apache.sentry.api.service.thrift.validator.GrantPrivilegeRequestValidator; +import org.apache.sentry.api.service.thrift.validator.RevokePrivilegeRequestValidator; +import org.apache.sentry.api.common.SentryServiceUtil; +import org.apache.sentry.service.common.ServiceConstants.ConfUtilties; +import org.apache.sentry.service.common.ServiceConstants.SentryEntityType; +import org.apache.sentry.service.common.ServiceConstants.ServerConfig; +import org.apache.sentry.api.common.Status; +import org.apache.sentry.service.thrift.TSentryResponseStatus; +import org.apache.thrift.TException; +import org.apache.log4j.Logger; + +import com.codahale.metrics.Timer; +import static com.codahale.metrics.MetricRegistry.name; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import com.google.common.base.Splitter; +import com.google.common.collect.ImmutableSet; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import com.google.common.collect.Sets; + +import static org.apache.sentry.hdfs.Updateable.Update; + +@SuppressWarnings("unused") +public class SentryPolicyStoreProcessor implements SentryPolicyService.Iface { + private static final Logger LOGGER = Logger.getLogger(SentryPolicyStoreProcessor.class); + private static final Logger AUDIT_LOGGER = Logger.getLogger(Constants.AUDIT_LOGGER_NAME); + + private final String name; + private final Configuration conf; + private final SentryStore sentryStore; + private final NotificationHandlerInvoker notificationHandlerInvoker; + private final ImmutableSet adminGroups; + private SentryMetrics sentryMetrics; + private final Timer hmsWaitTimer = + SentryMetrics.getInstance(). + getTimer(name(SentryPolicyStoreProcessor.class, "hms", "wait")); + + private List sentryPlugins = new LinkedList(); + + SentryPolicyStoreProcessor(String name, + Configuration conf, SentryStore store) throws Exception { + super(); + this.name = name; + this.conf = conf; + this.sentryStore = store; + this.notificationHandlerInvoker = new NotificationHandlerInvoker(conf, + createHandlers(conf)); + adminGroups = ImmutableSet.copyOf(toTrimedLower(Sets.newHashSet(conf.getStrings( + ServerConfig.ADMIN_GROUPS, new String[]{})))); + Iterable pluginClasses = ConfUtilties.CLASS_SPLITTER + .split(conf.get(ServerConfig.SENTRY_POLICY_STORE_PLUGINS, + ServerConfig.SENTRY_POLICY_STORE_PLUGINS_DEFAULT).trim()); + for (String pluginClassStr : pluginClasses) { + Class clazz = conf.getClassByName(pluginClassStr); + if (!SentryPolicyStorePlugin.class.isAssignableFrom(clazz)) { + throw new IllegalArgumentException("Sentry Plugin [" + + pluginClassStr + "] is not a " + + SentryPolicyStorePlugin.class.getName()); + } + SentryPolicyStorePlugin plugin = (SentryPolicyStorePlugin)clazz.newInstance(); + plugin.initialize(conf, sentryStore); + sentryPlugins.add(plugin); + } + initMetrics(); + } + + private void initMetrics() { + sentryMetrics = SentryMetrics.getInstance(); + sentryMetrics.addSentryStoreGauges(sentryStore); + sentryMetrics.initReporting(conf); + } + + public void stop() { + sentryStore.stop(); + } + + public void registerPlugin(SentryPolicyStorePlugin plugin) throws SentryPluginException { + plugin.initialize(conf, sentryStore); + sentryPlugins.add(plugin); + } + + @VisibleForTesting + static List createHandlers(Configuration conf) + throws SentrySiteConfigurationException { + List handlers = Lists.newArrayList(); + Iterable notificationHandlers = Splitter.onPattern("[\\s,]").trimResults() + .omitEmptyStrings().split(conf.get(PolicyStoreServerConfig.NOTIFICATION_HANDLERS, "")); + for (String notificationHandler : notificationHandlers) { + Class clazz = null; + try { + clazz = Class.forName(notificationHandler); + if (!NotificationHandler.class.isAssignableFrom(clazz)) { + throw new SentrySiteConfigurationException("Class " + notificationHandler + " is not a " + + NotificationHandler.class.getName()); + } + } catch (ClassNotFoundException e) { + throw new SentrySiteConfigurationException("Value " + notificationHandler + + " is not a class", e); + } + Preconditions.checkNotNull(clazz, "Error class cannot be null"); + try { + Constructor constructor = clazz.getConstructor(Configuration.class); + handlers.add((NotificationHandler)constructor.newInstance(conf)); + } catch (Exception e) { + throw new SentrySiteConfigurationException("Error attempting to create " + notificationHandler, e); + } + } + return handlers; + } + + @VisibleForTesting + public Configuration getSentryStoreConf() { + return conf; + } + + private static Set toTrimedLower(Set s) { + Set result = Sets.newHashSet(); + for (String v : s) { + result.add(v.trim().toLowerCase()); + } + return result; + } + + private boolean inAdminGroups(Set requestorGroups) { + Set trimmedRequestorGroups = toTrimedLower(requestorGroups); + return !Sets.intersection(adminGroups, trimmedRequestorGroups).isEmpty(); + } + + private void authorize(String requestorUser, Set requestorGroups) + throws SentryAccessDeniedException { + if (!inAdminGroups(requestorGroups)) { + String msg = "User: " + requestorUser + " is part of " + requestorGroups + + " which does not, intersect admin groups " + adminGroups; + LOGGER.warn(msg); + throw new SentryAccessDeniedException("Access denied to " + requestorUser); + } + } + + @Override + public TCreateSentryRoleResponse create_sentry_role( + TCreateSentryRoleRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.createRoleTimer.time(); + TCreateSentryRoleResponse response = new TCreateSentryRoleResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), + getRequestorGroups(request.getRequestorUserName())); + sentryStore.createSentryRole(request.getRoleName()); + response.setStatus(Status.OK()); + notificationHandlerInvoker.create_sentry_role(request, response); + } catch (SentryAlreadyExistsException e) { + String msg = "Role: " + request + " already exists."; + LOGGER.error(msg, e); + response.setStatus(Status.AlreadyExists(e.getMessage(), e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for create role: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleGrantPrivilegeResponse alter_sentry_role_grant_privilege + (TAlterSentryRoleGrantPrivilegeRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.grantTimer.time(); + TAlterSentryRoleGrantPrivilegeResponse response = new TAlterSentryRoleGrantPrivilegeResponse(); + try { + validateClientVersion(request.getProtocol_version()); + // There should only one field be set + if ( !(request.isSetPrivileges()^request.isSetPrivilege()) ) { + throw new SentryUserException("SENTRY API version is not right!"); + } + // Maintain compatibility for old API: Set privilege field to privileges field + if (request.isSetPrivilege()) { + request.setPrivileges(Sets.newHashSet(request.getPrivilege())); + } + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Map privilegesUpdateMap = new HashMap<>(); + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + plugin.onAlterSentryRoleGrantPrivilege(request, privilegesUpdateMap); + } + + if (!privilegesUpdateMap.isEmpty()) { + sentryStore.alterSentryRoleGrantPrivileges(request.getRequestorUserName(), + request.getRoleName(), request.getPrivileges(), privilegesUpdateMap); + } else { + sentryStore.alterSentryRoleGrantPrivileges(request.getRequestorUserName(), + request.getRoleName(), request.getPrivileges()); + } + GrantPrivilegeRequestValidator.validate(request); + response.setStatus(Status.OK()); + response.setPrivileges(request.getPrivileges()); + // Maintain compatibility for old API: Set privilege field to response + if (response.isSetPrivileges() && response.getPrivileges().size() == 1) { + response.setPrivilege(response.getPrivileges().iterator().next()); + } + notificationHandlerInvoker.alter_sentry_role_grant_privilege(request, + response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role: " + request.getRoleName() + " doesn't exist"; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryInvalidInputException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.InvalidInput(e.getMessage(), e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + Set jsonLogEntitys = JsonLogEntityFactory.getInstance().createJsonLogEntitys( + request, response, conf); + for (JsonLogEntity jsonLogEntity : jsonLogEntitys) { + AUDIT_LOGGER.info(jsonLogEntity.toJsonFormatLog()); + } + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for grant privilege to role: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleRevokePrivilegeResponse alter_sentry_role_revoke_privilege + (TAlterSentryRoleRevokePrivilegeRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.revokeTimer.time(); + TAlterSentryRoleRevokePrivilegeResponse response = new TAlterSentryRoleRevokePrivilegeResponse(); + try { + validateClientVersion(request.getProtocol_version()); + // There should only one field be set + if ( !(request.isSetPrivileges()^request.isSetPrivilege()) ) { + throw new SentryUserException("SENTRY API version is not right!"); + } + // Maintain compatibility for old API: Set privilege field to privileges field + if (request.isSetPrivilege()) { + request.setPrivileges(Sets.newHashSet(request.getPrivilege())); + } + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Map privilegesUpdateMap = new HashMap<>(); + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + plugin.onAlterSentryRoleRevokePrivilege(request, privilegesUpdateMap); + } + + if (!privilegesUpdateMap.isEmpty()) { + sentryStore.alterSentryRoleRevokePrivileges(request.getRequestorUserName(), + request.getRoleName(), request.getPrivileges(), privilegesUpdateMap); + } else { + sentryStore.alterSentryRoleRevokePrivileges(request.getRequestorUserName(), + request.getRoleName(), request.getPrivileges()); + } + RevokePrivilegeRequestValidator.validate(request); + response.setStatus(Status.OK()); + notificationHandlerInvoker.alter_sentry_role_revoke_privilege(request, + response); + } catch (SentryNoSuchObjectException e) { + StringBuilder msg = new StringBuilder(); + if (request.getPrivileges().size() > 0) { + for (TSentryPrivilege privilege : request.getPrivileges()) { + msg.append("Privilege: [server="); + msg.append(privilege.getServerName()); + msg.append(",db="); + msg.append(privilege.getDbName()); + msg.append(",table="); + msg.append(privilege.getTableName()); + msg.append(",URI="); + msg.append(privilege.getURI()); + msg.append(",action="); + msg.append(privilege.getAction()); + msg.append("] "); + } + msg.append("doesn't exist."); + } + LOGGER.error(msg.toString(), e); + response.setStatus(Status.NoSuchObject(msg.toString(), e)); + } catch (SentryInvalidInputException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.InvalidInput(e.getMessage(), e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + Set jsonLogEntitys = JsonLogEntityFactory.getInstance().createJsonLogEntitys( + request, response, conf); + for (JsonLogEntity jsonLogEntity : jsonLogEntitys) { + AUDIT_LOGGER.info(jsonLogEntity.toJsonFormatLog()); + } + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for revoke privilege from role: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TDropSentryRoleResponse drop_sentry_role( + TDropSentryRoleRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.dropRoleTimer.time(); + TDropSentryRoleResponse response = new TDropSentryRoleResponse(); + TSentryResponseStatus status; + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), + getRequestorGroups(request.getRequestorUserName())); + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Update update = null; + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + update = plugin.onDropSentryRole(request); + } + + if (update != null) { + sentryStore.dropSentryRole(request.getRoleName(), update); + } else { + sentryStore.dropSentryRole(request.getRoleName()); + } + response.setStatus(Status.OK()); + notificationHandlerInvoker.drop_sentry_role(request, response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role :" + request + " doesn't exist"; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for drop role: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleAddGroupsResponse alter_sentry_role_add_groups( + TAlterSentryRoleAddGroupsRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.grantRoleTimer.time(); + TAlterSentryRoleAddGroupsResponse response = new TAlterSentryRoleAddGroupsResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), + getRequestorGroups(request.getRequestorUserName())); + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Update update = null; + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + update = plugin.onAlterSentryRoleAddGroups(request); + } + if (update != null) { + sentryStore.alterSentryRoleAddGroups(request.getRequestorUserName(), + request.getRoleName(), request.getGroups(), update); + } else { + sentryStore.alterSentryRoleAddGroups(request.getRequestorUserName(), + request.getRoleName(), request.getGroups()); + } + response.setStatus(Status.OK()); + notificationHandlerInvoker.alter_sentry_role_add_groups(request, + response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role: " + request + " doesn't exist"; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for add role to group: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleAddUsersResponse alter_sentry_role_add_users( + TAlterSentryRoleAddUsersRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.grantRoleTimer.time(); + TAlterSentryRoleAddUsersResponse response = new TAlterSentryRoleAddUsersResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), getRequestorGroups(request.getRequestorUserName())); + sentryStore.alterSentryRoleAddUsers(request.getRoleName(), request.getUsers()); + response.setStatus(Status.OK()); + notificationHandlerInvoker.alter_sentry_role_add_users(request, response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role: " + request + " does not exist."; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for add role to user: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleDeleteUsersResponse alter_sentry_role_delete_users( + TAlterSentryRoleDeleteUsersRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.grantRoleTimer.time(); + TAlterSentryRoleDeleteUsersResponse response = new TAlterSentryRoleDeleteUsersResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), getRequestorGroups(request.getRequestorUserName())); + sentryStore.alterSentryRoleDeleteUsers(request.getRoleName(), + request.getUsers()); + response.setStatus(Status.OK()); + notificationHandlerInvoker.alter_sentry_role_delete_users(request, response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role: " + request + " does not exist."; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for delete role from user: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TAlterSentryRoleDeleteGroupsResponse alter_sentry_role_delete_groups( + TAlterSentryRoleDeleteGroupsRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.revokeRoleTimer.time(); + TAlterSentryRoleDeleteGroupsResponse response = new TAlterSentryRoleDeleteGroupsResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), + getRequestorGroups(request.getRequestorUserName())); + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Update update = null; + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + update = plugin.onAlterSentryRoleDeleteGroups(request); + } + + if (update != null) { + sentryStore.alterSentryRoleDeleteGroups(request.getRoleName(), + request.getGroups(), update); + } else { + sentryStore.alterSentryRoleDeleteGroups(request.getRoleName(), + request.getGroups()); + } + response.setStatus(Status.OK()); + notificationHandlerInvoker.alter_sentry_role_delete_groups(request, + response); + } catch (SentryNoSuchObjectException e) { + String msg = "Role: " + request + " does not exist."; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error adding groups to role: " + request; + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + + try { + AUDIT_LOGGER.info(JsonLogEntityFactory.getInstance() + .createJsonLogEntity(request, response, conf).toJsonFormatLog()); + } catch (Exception e) { + // if any exception, log the exception. + String msg = "Error creating audit log for delete role from group: " + e.getMessage(); + LOGGER.error(msg, e); + } + return response; + } + + @Override + public TListSentryRolesResponse list_sentry_roles_by_group( + TListSentryRolesRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.listRolesByGroupTimer.time(); + TListSentryRolesResponse response = new TListSentryRolesResponse(); + TSentryResponseStatus status; + Set roleSet = new HashSet(); + String subject = request.getRequestorUserName(); + boolean checkAllGroups = false; + try { + validateClientVersion(request.getProtocol_version()); + Set groups = getRequestorGroups(subject); + // Don't check admin permissions for listing requestor's own roles + if (AccessConstants.ALL.equalsIgnoreCase(request.getGroupName())) { + checkAllGroups = true; + } else { + boolean admin = inAdminGroups(groups); + //Only admin users can list all roles in the system ( groupname = null) + //Non admin users are only allowed to list only groups which they belong to + if(!admin && (request.getGroupName() == null || !groups.contains(request.getGroupName()))) { + throw new SentryAccessDeniedException("Access denied to " + subject); + } else { + groups.clear(); + groups.add(request.getGroupName()); + } + } + roleSet = sentryStore.getTSentryRolesByGroupName(groups, checkAllGroups); + response.setRoles(roleSet); + response.setStatus(Status.OK()); + } catch (SentryNoSuchObjectException e) { + response.setRoles(roleSet); + String msg = "Request: " + request + " couldn't be completed, message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + public TListSentryRolesResponse list_sentry_roles_by_user(TListSentryRolesForUserRequest request) + throws TException { + final Timer.Context timerContext = sentryMetrics.listRolesByGroupTimer.time(); + TListSentryRolesResponse response = new TListSentryRolesResponse(); + TSentryResponseStatus status; + Set roleSet = new HashSet(); + String requestor = request.getRequestorUserName(); + String userName = request.getUserName(); + boolean checkAllGroups = false; + try { + validateClientVersion(request.getProtocol_version()); + // userName can't be empty + if (StringUtils.isEmpty(userName)) { + throw new SentryAccessDeniedException("The user name can't be empty."); + } + + Set requestorGroups; + try { + requestorGroups = getRequestorGroups(requestor); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + return response; + } + + Set userGroups; + try { + userGroups = getRequestorGroups(userName); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + String msg = "Groups for user " + userName + " do not exist: " + e.getMessage(); + response.setStatus(Status.AccessDenied(msg, e)); + return response; + } + boolean isAdmin = inAdminGroups(requestorGroups); + + // Only admin users can list other user's roles in the system + // Non admin users are only allowed to list only their own roles related user and group + if (!isAdmin && !userName.equals(requestor)) { + throw new SentryAccessDeniedException("Access denied to list the roles for " + userName); + } + roleSet = sentryStore.getTSentryRolesByUserNames(Sets.newHashSet(userName)); + response.setRoles(roleSet); + response.setStatus(Status.OK()); + } catch (SentryNoSuchObjectException e) { + response.setRoles(roleSet); + String msg = "Role: " + request + " couldn't be retrieved."; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + @Override + public TListSentryPrivilegesResponse list_sentry_privileges_by_role( + TListSentryPrivilegesRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.listPrivilegesByRoleTimer.time(); + TListSentryPrivilegesResponse response = new TListSentryPrivilegesResponse(); + TSentryResponseStatus status; + Set privilegeSet = new HashSet(); + String subject = request.getRequestorUserName(); + try { + validateClientVersion(request.getProtocol_version()); + Set groups = getRequestorGroups(subject); + Boolean admin = inAdminGroups(groups); + if(!admin) { + Set roleNamesForGroups = toTrimedLower(sentryStore.getRoleNamesForGroups(groups)); + if(!roleNamesForGroups.contains(request.getRoleName().trim().toLowerCase())) { + throw new SentryAccessDeniedException("Access denied to " + subject); + } + } + if (request.isSetAuthorizableHierarchy()) { + TSentryAuthorizable authorizableHierarchy = request.getAuthorizableHierarchy(); + privilegeSet = sentryStore.getTSentryPrivileges(SentryEntityType.ROLE, Sets.newHashSet(request.getRoleName()), authorizableHierarchy); + } else { + privilegeSet = sentryStore.getAllTSentryPrivilegesByRoleName(request.getRoleName()); + } + response.setPrivileges(privilegeSet); + response.setStatus(Status.OK()); + } catch (SentryNoSuchObjectException e) { + response.setPrivileges(privilegeSet); + String msg = "Privilege: " + request + " couldn't be retrieved."; + LOGGER.error(msg, e); + response.setStatus(Status.NoSuchObject(msg, e)); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + /** + * This method was created specifically for ProviderBackend.getPrivileges() and is not meant + * to be used for general privilege retrieval. More details in the .thrift file. + */ + @Override + public TListSentryPrivilegesForProviderResponse list_sentry_privileges_for_provider( + TListSentryPrivilegesForProviderRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.listPrivilegesForProviderTimer.time(); + TListSentryPrivilegesForProviderResponse response = new TListSentryPrivilegesForProviderResponse(); + response.setPrivileges(new HashSet()); + try { + validateClientVersion(request.getProtocol_version()); + Set privilegesForProvider = + sentryStore.listSentryPrivilegesForProvider(request.getGroups(), request.getUsers(), + request.getRoleSet(), request.getAuthorizableHierarchy()); + response.setPrivileges(privilegesForProvider); + if (privilegesForProvider == null + || privilegesForProvider.size() == 0 + && request.getAuthorizableHierarchy() != null + && sentryStore.hasAnyServerPrivileges(request.getGroups(), request.getUsers(), + request.getRoleSet(), request.getAuthorizableHierarchy().getServer())) { + + // REQUIRED for ensuring 'default' Db is accessible by any user + // with privileges to atleast 1 object with the specific server as root + + // Need some way to specify that even though user has no privilege + // For the specific AuthorizableHierarchy.. he has privilege on + // atleast 1 object in the server hierarchy + HashSet serverPriv = Sets.newHashSet("server=+"); + response.setPrivileges(serverPriv); + } + response.setStatus(Status.OK()); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + // retrieve the group mapping for the given user name + private Set getRequestorGroups(String userName) + throws SentryUserException { + return getGroupsFromUserName(this.conf, userName); + } + + public static Set getGroupsFromUserName(Configuration conf, + String userName) throws SentryUserException { + String groupMapping = conf.get(ServerConfig.SENTRY_STORE_GROUP_MAPPING, + ServerConfig.SENTRY_STORE_GROUP_MAPPING_DEFAULT); + String authResoruce = conf + .get(ServerConfig.SENTRY_STORE_GROUP_MAPPING_RESOURCE); + + // load the group mapping provider class + GroupMappingService groupMappingService; + try { + Constructor constrctor = Class.forName(groupMapping) + .getDeclaredConstructor(Configuration.class, String.class); + constrctor.setAccessible(true); + groupMappingService = (GroupMappingService) constrctor + .newInstance(new Object[] { conf, authResoruce }); + } catch (NoSuchMethodException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (SecurityException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (ClassNotFoundException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (InstantiationException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (IllegalAccessException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (IllegalArgumentException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } catch (InvocationTargetException e) { + throw new SentryUserException("Unable to instantiate group mapping", e); + } + return groupMappingService.getGroups(userName); + } + + @Override + public TDropPrivilegesResponse drop_sentry_privilege( + TDropPrivilegesRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.dropPrivilegeTimer.time(); + TDropPrivilegesResponse response = new TDropPrivilegesResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), adminGroups); + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Update update = null; + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + update = plugin.onDropSentryPrivilege(request); + } + if (update != null) { + sentryStore.dropPrivilege(request.getAuthorizable(), update); + } else { + sentryStore.dropPrivilege(request.getAuthorizable()); + } + response.setStatus(Status.OK()); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + @Override + public TRenamePrivilegesResponse rename_sentry_privilege( + TRenamePrivilegesRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.renamePrivilegeTimer.time(); + TRenamePrivilegesResponse response = new TRenamePrivilegesResponse(); + try { + validateClientVersion(request.getProtocol_version()); + authorize(request.getRequestorUserName(), adminGroups); + + // TODO: now only has SentryPlugin. Once add more SentryPolicyStorePlugins, + // TODO: need to differentiate the updates for different Plugins. + Preconditions.checkState(sentryPlugins.size() <= 1); + Update update = null; + for (SentryPolicyStorePlugin plugin : sentryPlugins) { + update = plugin.onRenameSentryPrivilege(request); + } + if (update != null) { + sentryStore.renamePrivilege(request.getOldAuthorizable(), + request.getNewAuthorizable(), update); + } else { + sentryStore.renamePrivilege(request.getOldAuthorizable(), + request.getNewAuthorizable()); + } + response.setStatus(Status.OK()); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (SentryInvalidInputException e) { + response.setStatus(Status.InvalidInput(e.getMessage(), e)); + } + catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.close(); + } + return response; + } + + @Override + public TListSentryPrivilegesByAuthResponse list_sentry_privileges_by_authorizable( + TListSentryPrivilegesByAuthRequest request) throws TException { + final Timer.Context timerContext = sentryMetrics.listPrivilegesByAuthorizableTimer.time(); + TListSentryPrivilegesByAuthResponse response = new TListSentryPrivilegesByAuthResponse(); + Map authRoleMap = Maps.newHashMap(); + String subject = request.getRequestorUserName(); + Set requestedGroups = request.getGroups(); + TSentryActiveRoleSet requestedRoleSet = request.getRoleSet(); + try { + validateClientVersion(request.getProtocol_version()); + Set memberGroups = getRequestorGroups(subject); + if(!inAdminGroups(memberGroups)) { + // disallow non-admin to lookup groups that they are not part of + if (requestedGroups != null && !requestedGroups.isEmpty()) { + for (String requestedGroup : requestedGroups) { + if (!memberGroups.contains(requestedGroup)) { + // if user doesn't belong to one of the requested group then raise error + throw new SentryAccessDeniedException("Access denied to " + subject); + } + } + } else { + // non-admin's search is limited to it's own groups + requestedGroups = memberGroups; + } + + // disallow non-admin to lookup roles that they are not part of + if (requestedRoleSet != null && !requestedRoleSet.isAll()) { + Set roles = toTrimedLower(sentryStore + .getRoleNamesForGroups(memberGroups)); + for (String role : toTrimedLower(requestedRoleSet.getRoles())) { + if (!roles.contains(role)) { + throw new SentryAccessDeniedException("Access denied to " + + subject); + } + } + } + } + + // If user is not part of any group.. return empty response + for (TSentryAuthorizable authorizable : request.getAuthorizableSet()) { + authRoleMap.put(authorizable, sentryStore + .listSentryPrivilegesByAuthorizable(requestedGroups, + request.getRoleSet(), authorizable, inAdminGroups(memberGroups))); + + // TODO: add privileges associated with user by calling listSentryPrivilegesByAuthorizableForUser + } + response.setPrivilegesMapByAuth(authRoleMap); + response.setStatus(Status.OK()); + // TODO : Sentry - HDFS : Have to handle this + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } finally { + timerContext.stop(); + } + return response; + } + + /** + * Respond to a request for a config value in the sentry server. The client + * can request any config value that starts with "sentry." and doesn't contain + * "keytab". + * @param request Contains config parameter sought and default if not found + * @return The response, containing the value and status + * @throws TException + */ + @Override + public TSentryConfigValueResponse get_sentry_config_value( + TSentryConfigValueRequest request) throws TException { + + final String requirePattern = "^sentry\\..*"; + final String excludePattern = ".*keytab.*|.*\\.jdbc\\..*|.*password.*"; + + TSentryConfigValueResponse response = new TSentryConfigValueResponse(); + String attr = request.getPropertyName(); + + try { + validateClientVersion(request.getProtocol_version()); + } catch (SentryThriftAPIMismatchException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.THRIFT_VERSION_MISMATCH(e.getMessage(), e)); + } + // Only allow config parameters like... + if (!Pattern.matches(requirePattern, attr) || + Pattern.matches(excludePattern, attr)) { + String msg = "Attempted access of the configuration property " + attr + + " was denied"; + LOGGER.error(msg); + response.setStatus(Status.AccessDenied(msg, + new SentryAccessDeniedException(msg))); + return response; + } + + response.setValue(conf.get(attr,request.getDefaultValue())); + response.setStatus(Status.OK()); + return response; + } + + @VisibleForTesting + static void validateClientVersion(int protocolVersion) throws SentryThriftAPIMismatchException { + if (ThriftConstants.TSENTRY_SERVICE_VERSION_CURRENT != protocolVersion) { + String msg = "Sentry thrift API protocol version mismatch: Client thrift version " + + "is: " + protocolVersion + " , server thrift verion " + + "is " + ThriftConstants.TSENTRY_SERVICE_VERSION_CURRENT; + throw new SentryThriftAPIMismatchException(msg); + } + } + + // get the sentry mapping data and return the data with map structure + @Override + public TSentryExportMappingDataResponse export_sentry_mapping_data( + TSentryExportMappingDataRequest request) throws TException { + TSentryExportMappingDataResponse response = new TSentryExportMappingDataResponse(); + try { + String requestor = request.getRequestorUserName(); + Set memberGroups = getRequestorGroups(requestor); + String objectPath = request.getObjectPath(); + String databaseName = null; + String tableName = null; + + Map objectMap = + SentryServiceUtil.parseObjectPath(objectPath); + databaseName = objectMap.get(PolicyFileConstants.PRIVILEGE_DATABASE_NAME); + tableName = objectMap.get(PolicyFileConstants.PRIVILEGE_TABLE_NAME); + + if (!inAdminGroups(memberGroups)) { + // disallow non-admin to import the metadata of sentry + throw new SentryAccessDeniedException("Access denied to " + requestor + + " for export the metadata of sentry."); + } + TSentryMappingData tSentryMappingData = new TSentryMappingData(); + Map> rolePrivileges = + sentryStore.getRoleNameTPrivilegesMap(databaseName, tableName); + tSentryMappingData.setRolePrivilegesMap(rolePrivileges); + Set roleNames = rolePrivileges.keySet(); + // roleNames should be null if databaseName == null and tableName == null + if (databaseName == null && tableName == null) { + roleNames = null; + } + List>> mapList = sentryStore.getGroupUserRoleMapList( + roleNames); + tSentryMappingData.setGroupRolesMap(mapList.get( + SentryStore.INDEX_GROUP_ROLES_MAP)); + tSentryMappingData.setUserRolesMap(mapList.get(SentryStore.INDEX_USER_ROLES_MAP)); + + response.setMappingData(tSentryMappingData); + response.setStatus(Status.OK()); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setMappingData(new TSentryMappingData()); + response.setStatus(Status.RuntimeError(msg, e)); + } + return response; + } + + // import the sentry mapping data + @Override + public TSentryImportMappingDataResponse import_sentry_mapping_data( + TSentryImportMappingDataRequest request) throws TException { + TSentryImportMappingDataResponse response = new TSentryImportMappingDataResponse(); + try { + String requestor = request.getRequestorUserName(); + Set memberGroups = getRequestorGroups(requestor); + if (!inAdminGroups(memberGroups)) { + // disallow non-admin to import the metadata of sentry + throw new SentryAccessDeniedException("Access denied to " + requestor + + " for import the metadata of sentry."); + } + sentryStore.importSentryMetaData(request.getMappingData(), request.isOverwriteRole()); + response.setStatus(Status.OK()); + } catch (SentryAccessDeniedException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryGroupNotFoundException e) { + LOGGER.error(e.getMessage(), e); + response.setStatus(Status.AccessDenied(e.getMessage(), e)); + } catch (SentryInvalidInputException e) { + String msg = "Invalid input privilege object"; + LOGGER.error(msg, e); + response.setStatus(Status.InvalidInput(msg, e)); + } catch (Exception e) { + String msg = "Unknown error for request: " + request + ", message: " + e.getMessage(); + LOGGER.error(msg, e); + response.setStatus(Status.RuntimeError(msg, e)); + } + return response; + } + + @Override + public TSentrySyncIDResponse sentry_sync_notifications(TSentrySyncIDRequest request) + throws TException { + TSentrySyncIDResponse response = new TSentrySyncIDResponse(); + try (Timer.Context timerContext = hmsWaitTimer.time()) { + // Wait until Sentry Server processes specified HMS Notification ID. + response.setId(sentryStore.getCounterWait().waitFor(request.getId())); + response.setStatus(Status.OK()); + } catch (InterruptedException e) { + String msg = String.format("wait request for id %d is interrupted", + request.getId()); + LOGGER.error(msg, e); + response.setId(0); + response.setStatus(Status.RuntimeError(msg, e)); + Thread.currentThread().interrupt(); + } catch (TimeoutException e) { + String msg = String.format("timed out wait request for id %d", request.getId()); + LOGGER.warn(msg, e); + response.setId(0); + response.setStatus(Status.RuntimeError(msg, e)); + } + return response; + } +} http://git-wip-us.apache.org/repos/asf/sentry/blob/7db84b2f/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java ---------------------------------------------------------------------- diff --git a/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java new file mode 100644 index 0000000..fd209b7 --- /dev/null +++ b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorFactory.java @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.sentry.api.service.thrift; + +import org.apache.hadoop.conf.Configuration; +import org.apache.sentry.api.common.ApiConstants.SentryPolicyServiceConstants; +import org.apache.sentry.provider.db.service.persistent.SentryStore; +import org.apache.sentry.service.thrift.ProcessorFactory; +import org.apache.thrift.TMultiplexedProcessor; +import org.apache.thrift.TProcessor; + +public class SentryPolicyStoreProcessorFactory extends ProcessorFactory { + public SentryPolicyStoreProcessorFactory(Configuration conf) { + super(conf); + } + + public boolean register(TMultiplexedProcessor multiplexedProcessor, + SentryStore sentryStore) throws Exception { + SentryPolicyStoreProcessor sentryServiceHandler = + new SentryPolicyStoreProcessor(SentryPolicyServiceConstants.SENTRY_POLICY_SERVICE_NAME, + conf, sentryStore); + TProcessor processor = + new SentryProcessorWrapper(sentryServiceHandler); + multiplexedProcessor.registerProcessor( + SentryPolicyServiceConstants.SENTRY_POLICY_SERVICE_NAME, processor); + return true; + } +} http://git-wip-us.apache.org/repos/asf/sentry/blob/7db84b2f/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java ---------------------------------------------------------------------- diff --git a/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java new file mode 100644 index 0000000..befe6c3 --- /dev/null +++ b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java @@ -0,0 +1,240 @@ +package org.apache.sentry.api.service.thrift; + +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import com.codahale.metrics.servlets.AdminServlet; +import com.google.common.base.Preconditions; + +import java.io.IOException; +import java.net.URL; +import java.util.EnumSet; +import java.util.EventListener; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import com.google.common.base.Splitter; +import com.google.common.base.Strings; +import com.google.common.collect.Sets; +import javax.servlet.DispatcherType; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.security.SecurityUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.authentication.server.AuthenticationFilter; +import org.apache.sentry.service.common.ServiceConstants.ServerConfig; +import org.eclipse.jetty.security.ConstraintMapping; +import org.eclipse.jetty.security.ConstraintSecurityHandler; +import org.eclipse.jetty.server.Connector; +import org.eclipse.jetty.server.Handler; +import org.eclipse.jetty.server.HttpConfiguration; +import org.eclipse.jetty.server.HttpConnectionFactory; +import org.eclipse.jetty.server.SecureRequestCustomizer; +import org.eclipse.jetty.server.ServerConnector; +import org.eclipse.jetty.server.SslConnectionFactory; +import org.eclipse.jetty.server.handler.ContextHandler; +import org.eclipse.jetty.server.handler.ContextHandlerCollection; +import org.eclipse.jetty.server.handler.ResourceHandler; +import org.eclipse.jetty.server.Server; +import org.eclipse.jetty.servlet.FilterHolder; +import org.eclipse.jetty.servlet.ServletContextHandler; +import org.eclipse.jetty.servlet.ServletHolder; +import org.eclipse.jetty.util.resource.Resource; +import org.eclipse.jetty.util.security.Constraint; +import org.eclipse.jetty.util.ssl.SslContextFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class SentryWebServer { + + private static final Logger LOGGER = LoggerFactory.getLogger(SentryWebServer.class); + private static final String RESOURCE_DIR = "/webapp"; + private static final String WELCOME_PAGE = "SentryService.html"; + + private Server server; + + public SentryWebServer(List listeners, int port, Configuration conf) { + server = new Server(); + + // Create a channel connector for "http/https" requests + ServerConnector connector; + if (conf.getBoolean(ServerConfig.SENTRY_WEB_USE_SSL, false)) { + SslContextFactory sslContextFactory = new SslContextFactory(); + sslContextFactory.setKeyStorePath(conf.get(ServerConfig.SENTRY_WEB_SSL_KEYSTORE_PATH, "")); + sslContextFactory.setKeyStorePassword( + conf.get(ServerConfig.SENTRY_WEB_SSL_KEYSTORE_PASSWORD, "")); + // Exclude SSL blacklist protocols + sslContextFactory.setExcludeProtocols(ServerConfig.SENTRY_SSL_PROTOCOL_BLACKLIST_DEFAULT); + Set moreExcludedSSLProtocols = + Sets.newHashSet(Splitter.on(",").trimResults().omitEmptyStrings() + .split(Strings.nullToEmpty(conf.get(ServerConfig.SENTRY_SSL_PROTOCOL_BLACKLIST)))); + sslContextFactory.addExcludeProtocols(moreExcludedSSLProtocols.toArray( + new String[moreExcludedSSLProtocols.size()])); + + HttpConfiguration httpConfiguration = new HttpConfiguration(); + httpConfiguration.setSecurePort(port); + httpConfiguration.setSecureScheme("https"); + httpConfiguration.addCustomizer(new SecureRequestCustomizer()); + + connector = new ServerConnector( + server, + new SslConnectionFactory(sslContextFactory, "http/1.1"), + new HttpConnectionFactory(httpConfiguration)); + + LOGGER.info("Now using SSL mode."); + } else { + connector = new ServerConnector(server, new HttpConnectionFactory()); + } + + connector.setPort(port); + server.setConnectors(new Connector[] { connector }); + + ServletContextHandler servletContextHandler = new ServletContextHandler(); + ServletHolder servletHolder = new ServletHolder(AdminServlet.class); + servletContextHandler.addServlet(servletHolder, "/*"); + + for(EventListener listener:listeners) { + servletContextHandler.addEventListener(listener); + } + + servletContextHandler.addServlet(new ServletHolder(ConfServlet.class), "/conf"); + + if (conf.getBoolean(ServerConfig.SENTRY_WEB_ADMIN_SERVLET_ENABLED, + ServerConfig.SENTRY_WEB_ADMIN_SERVLET_ENABLED_DEFAULT)) { + servletContextHandler.addServlet( + new ServletHolder(SentryAdminServlet.class), "/admin/*"); + } + servletContextHandler.getServletContext() + .setAttribute(ConfServlet.CONF_CONTEXT_ATTRIBUTE, conf); + + servletContextHandler.addServlet(new ServletHolder(LogLevelServlet.class), "/admin/logLevel"); + + if (conf.getBoolean(ServerConfig.SENTRY_WEB_PUBSUB_SERVLET_ENABLED, + ServerConfig.SENTRY_WEB_PUBSUB_SERVLET_ENABLED_DEFAULT)) { + servletContextHandler.addServlet(new ServletHolder(PubSubServlet.class), "/admin/publishMessage"); + } + + ResourceHandler resourceHandler = new ResourceHandler(); + resourceHandler.setDirectoriesListed(true); + URL url = this.getClass().getResource(RESOURCE_DIR); + try { + resourceHandler.setBaseResource(Resource.newResource(url.toString())); + } catch (IOException e) { + LOGGER.error("Got exception while setBaseResource for Sentry Service web UI", e); + } + resourceHandler.setWelcomeFiles(new String[]{WELCOME_PAGE}); + ContextHandler contextHandler= new ContextHandler(); + contextHandler.setHandler(resourceHandler); + + ContextHandlerCollection contextHandlerCollection = new ContextHandlerCollection(); + contextHandlerCollection.setHandlers(new Handler[]{contextHandler, servletContextHandler}); + + String authMethod = conf.get(ServerConfig.SENTRY_WEB_SECURITY_TYPE); + if (!ServerConfig.SENTRY_WEB_SECURITY_TYPE_NONE.equalsIgnoreCase(authMethod)) { + /** + * SentryAuthFilter is a subclass of AuthenticationFilter and + * AuthenticationFilter tagged as private and unstable interface: + * While there are not guarantees that this interface will not change, + * it is fairly stable and used by other projects (ie - Oozie) + */ + FilterHolder filterHolder = servletContextHandler.addFilter(SentryAuthFilter.class, "/*", EnumSet.of(DispatcherType.REQUEST)); + filterHolder.setInitParameters(loadWebAuthenticationConf(conf)); + } + + server.setHandler(disableTraceMethod(contextHandlerCollection)); + } + + /** + * Disables the HTTP TRACE method request which leads to Cross-Site Tracking (XST) problems. + * + * To disable it, we need to wrap the Handler (which has the HTTP TRACE enabled) with + * a constraint that denies access to the HTTP TRACE method. + * + * @param handler The Handler which has the HTTP TRACE enabled. + * @return A new Handler wrapped with the HTTP TRACE constraint and the Handler passed as parameter. + */ + private Handler disableTraceMethod(Handler handler) { + Constraint disableTraceConstraint = new Constraint(); + disableTraceConstraint.setName("Disable TRACE"); + disableTraceConstraint.setAuthenticate(true); + + ConstraintMapping mapping = new ConstraintMapping(); + mapping.setConstraint(disableTraceConstraint); + mapping.setMethod("TRACE"); + mapping.setPathSpec("/"); + + ConstraintSecurityHandler constraintSecurityHandler = new ConstraintSecurityHandler(); + constraintSecurityHandler.addConstraintMapping(mapping); + constraintSecurityHandler.setHandler(handler); + + return constraintSecurityHandler; + } + + public void start() throws Exception{ + server.start(); + } + public void stop() throws Exception{ + server.stop(); + } + public boolean isAlive() { + return server != null && server.isStarted(); + } + private static Map loadWebAuthenticationConf(Configuration conf) { + Map prop = new HashMap(); + prop.put(AuthenticationFilter.CONFIG_PREFIX, ServerConfig.SENTRY_WEB_SECURITY_PREFIX); + String allowUsers = conf.get(ServerConfig.SENTRY_WEB_SECURITY_ALLOW_CONNECT_USERS); + if (allowUsers == null || allowUsers.equals("")) { + allowUsers = conf.get(ServerConfig.ALLOW_CONNECT); + conf.set(ServerConfig.SENTRY_WEB_SECURITY_ALLOW_CONNECT_USERS, allowUsers); + } + validateConf(conf); + for (Map.Entry entry : conf) { + String name = entry.getKey(); + if (name.startsWith(ServerConfig.SENTRY_WEB_SECURITY_PREFIX)) { + String value = conf.get(name); + prop.put(name, value); + } + } + return prop; + } + + private static void validateConf(Configuration conf) { + String authHandlerName = conf.get(ServerConfig.SENTRY_WEB_SECURITY_TYPE); + Preconditions.checkNotNull(authHandlerName, "Web authHandler should not be null."); + String allowUsers = conf.get(ServerConfig.SENTRY_WEB_SECURITY_ALLOW_CONNECT_USERS); + Preconditions.checkNotNull(allowUsers, "Allow connect user(s) should not be null."); + if (ServerConfig.SENTRY_WEB_SECURITY_TYPE_KERBEROS.equalsIgnoreCase(authHandlerName)) { + String principal = conf.get(ServerConfig.SENTRY_WEB_SECURITY_PRINCIPAL); + Preconditions.checkNotNull(principal, "Kerberos principal should not be null."); + Preconditions.checkArgument(principal.length() != 0, "Kerberos principal is not right."); + String keytabFile = conf.get(ServerConfig.SENTRY_WEB_SECURITY_KEYTAB); + Preconditions.checkNotNull(keytabFile, "Keytab File should not be null."); + Preconditions.checkArgument(keytabFile.length() != 0, "Keytab File is not right."); + try { + UserGroupInformation.setConfiguration(conf); + String hostPrincipal = SecurityUtil.getServerPrincipal(principal, ServerConfig.RPC_ADDRESS_DEFAULT); + UserGroupInformation.loginUserFromKeytab(hostPrincipal, keytabFile); + } catch (IOException ex) { + throw new IllegalArgumentException("Can't use Kerberos authentication, principal [" + + principal + "] keytab [" + keytabFile + "]", ex); + } + LOGGER.info("Using Kerberos authentication, principal [{}] keytab [{}]", principal, keytabFile); + } + } +} http://git-wip-us.apache.org/repos/asf/sentry/blob/7db84b2f/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java ---------------------------------------------------------------------- diff --git a/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java new file mode 100644 index 0000000..52f25dc --- /dev/null +++ b/sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/SentryPolicyStorePlugin.java @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.sentry.provider.db; + +import org.apache.hadoop.conf.Configuration; +import org.apache.sentry.core.common.exception.SentryInvalidInputException; +import org.apache.sentry.core.common.exception.SentryUserException; +import org.apache.sentry.provider.db.service.persistent.SentryStore; +import org.apache.sentry.api.service.thrift.TAlterSentryRoleAddGroupsRequest; +import org.apache.sentry.api.service.thrift.TAlterSentryRoleDeleteGroupsRequest; +import org.apache.sentry.api.service.thrift.TAlterSentryRoleGrantPrivilegeRequest; +import org.apache.sentry.api.service.thrift.TAlterSentryRoleRevokePrivilegeRequest; +import org.apache.sentry.api.service.thrift.TDropPrivilegesRequest; +import org.apache.sentry.api.service.thrift.TDropSentryRoleRequest; +import org.apache.sentry.api.service.thrift.TRenamePrivilegesRequest; +import org.apache.sentry.api.service.thrift.TSentryPrivilege; + +import java.util.Map; +import java.util.Set; + +import static org.apache.sentry.hdfs.Updateable.Update; + +/** + * Interface for processing delta changes of Sentry permission and generate corresponding + * update. The updates will be persisted into Sentry store afterwards along with the actual + * operation. + * + * TODO: SENTRY-1588: add user level privilege change support. e.g. onAlterSentryRoleDeleteUsers, + * TODO: onAlterSentryRoleDeleteUsers. + */ +public interface SentryPolicyStorePlugin { + + @SuppressWarnings("serial") + class SentryPluginException extends SentryUserException { + public SentryPluginException(String msg) { + super(msg); + } + public SentryPluginException(String msg, Throwable t) { + super(msg, t); + } + } + + void initialize(Configuration conf, SentryStore sentryStore) throws SentryPluginException; + + Update onAlterSentryRoleAddGroups(TAlterSentryRoleAddGroupsRequest tRequest) throws SentryPluginException; + + Update onAlterSentryRoleDeleteGroups(TAlterSentryRoleDeleteGroupsRequest tRequest) throws SentryPluginException; + + void onAlterSentryRoleGrantPrivilege(TAlterSentryRoleGrantPrivilegeRequest tRequest, + Map privilegesUpdateMap) throws SentryPluginException; + + void onAlterSentryRoleRevokePrivilege(TAlterSentryRoleRevokePrivilegeRequest tRequest, + Map privilegesUpdateMap) throws SentryPluginException; + + /** + * Used to create an update when privileges are granted to user. + * @param userName + * @param privileges + * @param privilegesUpdateMap + * @throws SentryPluginException + */ + void onAlterSentryUserGrantPrivilege(String userName, Set privileges, + Map privilegesUpdateMap) throws SentryPluginException; + + /** + * Used to create an update when privileges are revoked from user. + * @param userName + * @param privileges + * @param privilegesUpdateMap + * @throws SentryPluginException + */ + void onAlterSentryUserRevokePrivilege(String userName, Set privileges, + Map privilegesUpdateMap) throws SentryPluginException; + + Update onDropSentryRole(TDropSentryRoleRequest tRequest) throws SentryPluginException; + + Update onRenameSentryPrivilege(TRenamePrivilegesRequest request) + throws SentryPluginException, SentryInvalidInputException; + + Update onDropSentryPrivilege(TDropPrivilegesRequest request) throws SentryPluginException; +}