sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Ma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-1119) Allow data engines to specify the ActionFactory from configuration
Date Thu, 10 Mar 2016 02:14:40 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188512#comment-15188512
] 

Colin Ma commented on SENTRY-1119:
----------------------------------

[~bdmogal], left comment in the RB. The patch has some problems and can't pass the pre-commit.
I think this shouldn't be a sub-task for SENTRY-999, change it to an isolated JIRA.

> Allow data engines to specify the ActionFactory from configuration
> ------------------------------------------------------------------
>
>                 Key: SENTRY-1119
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1119
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Service
>    Affects Versions: 1.6.0
>            Reporter: Bhooshan Mogal
>            Assignee: Bhooshan Mogal
>             Fix For: 1.7.0
>
>         Attachments: SENTRY-1119.001.patch, SENTRY-1119.002.patch
>
>
> {{PrivilegeOperatePersistence}} uses a hard-coded map of component to {{ActionFactory}}
to figure out the {{ActionFactory}} for a given component. This prevents external data engines
from integrating easily with Sentry without modifying Sentry code.
> From mailing list discussion with [~colin_mjj]
> {noformat}
> I think the hardcoded map you pointed should be improved, make this to be configurable
or remove this.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message