sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-967) Use the Maven Dependency Plugin to download artifacts for the Sqoop tests
Date Wed, 09 Mar 2016 23:08:40 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188273#comment-15188273
] 

Hadoop QA commented on SENTRY-967:
----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12773851/SENTRY-967.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1329/console

This message is automatically generated.

> Use the Maven Dependency Plugin to download artifacts for the Sqoop tests
> -------------------------------------------------------------------------
>
>                 Key: SENTRY-967
>                 URL: https://issues.apache.org/jira/browse/SENTRY-967
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Trivial
>             Fix For: 1.8.0
>
>         Attachments: SENTRY-967.patch
>
>
> Currently the Maven antrun plugin is used to download a copy of Tomcat (6) and the Sqoop
server to a "thirdparty" directory in the "sentry-tests/sentry-tests-sqoop" directory.
> However there are a number of problems with this approach:
> a) You are not downloading to a temporary directory (I guess to save having to download
the artifacts on every build). This is not good practice, as a "mvn clean" doesn't actually
clean this directory
> b) If the download is corrupted, the corrupted artifact will stay in "thirdparty", as
the directory is not removed as part of the build process.
> c) The antrun/bash approach means that bash must be installed on the machine, which might
be problematic (e.g. on windows)
> A better approach is to use the Maven dependency plugin to download the artifacts and
copy them to a directory in the "target" directory of the tests. The artifacts get downloaded
to the local maven repository, so after the first download, the build won't have to redownload
anything. It should work on every platform as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message