Return-Path: X-Original-To: apmail-sentry-commits-archive@minotaur.apache.org Delivered-To: apmail-sentry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4897818A4C for ; Wed, 3 Feb 2016 01:38:45 +0000 (UTC) Received: (qmail 5120 invoked by uid 500); 3 Feb 2016 01:38:45 -0000 Delivered-To: apmail-sentry-commits-archive@sentry.apache.org Received: (qmail 5065 invoked by uid 500); 3 Feb 2016 01:38:45 -0000 Mailing-List: contact commits-help@sentry.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.incubator.apache.org Delivered-To: mailing list commits@sentry.incubator.apache.org Received: (qmail 5055 invoked by uid 99); 3 Feb 2016 01:38:45 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 01:38:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CAEFB18027C for ; Wed, 3 Feb 2016 01:38:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.436 X-Spam-Level: X-Spam-Status: No, score=0.436 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.545, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yvaVHFM8yIPR for ; Wed, 3 Feb 2016 01:38:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 7F661429E2 for ; Wed, 3 Feb 2016 01:38:40 +0000 (UTC) Received: (qmail 5027 invoked by uid 99); 3 Feb 2016 01:38:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 01:38:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D30B82C14F7 for ; Wed, 3 Feb 2016 01:38:39 +0000 (UTC) Date: Wed, 3 Feb 2016 01:38:39 +0000 (UTC) From: "Gregory Chanan (JIRA)" To: commits@sentry.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (SENTRY-1047) Use existing validators in SentryShellSolr MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Gregory Chanan created SENTRY-1047: -------------------------------------- Summary: Use existing validators in SentryShellSolr Key: SENTRY-1047 URL: https://issues.apache.org/jira/browse/SENTRY-1047 Project: Sentry Issue Type: Task Components: Service, Solr Plugin Affects Versions: 1.7.0 Reporter: Gregory Chanan Assignee: Gregory Chanan Fix For: 1.7.0 Right now, following the pattern of the Hive shell, the Solr shell manually implements validators, i.e.: https://github.com/apache/incubator-sentry/blob/597a3cdd319be84f2417c96d24db01553f264551/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java#L115-L130 It would be better if we automatically used the existing validators, so they don't need to be implemented in multiple places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)