sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Ma (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SENTRY-1051) The policy Privilege implementations could be consolidated
Date Sat, 06 Feb 2016 02:38:39 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135482#comment-15135482
] 

Colin Ma edited comment on SENTRY-1051 at 2/6/16 2:38 AM:
----------------------------------------------------------

[~coheig], [~sravya], I also worked on the SENTRY-1004 to remove the duplicated Privilege
for every component.
IMO, components needn't their own Privilege(like DBWildcardPrivilege, SearchWildcardPrivilege,
etc). Sentry should have a common privilege for all these components.
The compare of action should also be improved in Privilege.imply(). BitFieldAction was created
in Sentry for a long time, it's a better way to compare the action and should be used in Privilege.imply().


was (Author: colinma):
[~coheig], [~sravya], I also worked on the SENTRY-1004 to remove the duplicated Privilege
for every component.
IMO, components needn't their own Privilege(like DBWildcardPrivilege, SearchWildcardPrivilege,
etc). Sentry should have a common privilege for all these components.
The compare of action should also be improvement in Privilege.imply(). BitFieldAction was
created in Sentry for a long time, it's a better way to compare the action and should be used
in Privilege.imply().

> The policy Privilege implementations could be consolidated
> ----------------------------------------------------------
>
>                 Key: SENTRY-1051
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1051
>             Project: Sentry
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.7.0
>
>         Attachments: 0001-SENTRY-1051-The-policy-Privilege-implementations-cou.patch
>
>
> The policy Privilege implementations could be consolidated as they all share similar
code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message