Return-Path: X-Original-To: apmail-sentry-commits-archive@minotaur.apache.org Delivered-To: apmail-sentry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A52111E2F for ; Tue, 9 Sep 2014 10:13:50 +0000 (UTC) Received: (qmail 49571 invoked by uid 500); 9 Sep 2014 10:13:50 -0000 Delivered-To: apmail-sentry-commits-archive@sentry.apache.org Received: (qmail 49525 invoked by uid 500); 9 Sep 2014 10:13:50 -0000 Mailing-List: contact commits-help@sentry.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.incubator.apache.org Delivered-To: mailing list commits@sentry.incubator.apache.org Received: (qmail 49495 invoked by uid 99); 9 Sep 2014 10:13:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 10:13:50 +0000 X-ASF-Spam-Status: No, hits=-2001.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 09 Sep 2014 10:13:48 +0000 Received: (qmail 48828 invoked by uid 99); 9 Sep 2014 10:13:28 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 10:13:28 +0000 Date: Tue, 9 Sep 2014 10:13:28 +0000 (UTC) From: "Dapeng Sun (JIRA)" To: commits@sentry.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SENTRY-390) Extend Thrift API to support column-level privilege MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SENTRY-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dapeng Sun updated SENTRY-390: ------------------------------ Attachment: SENTRY-390.002.patch > Extend Thrift API to support column-level privilege > --------------------------------------------------- > > Key: SENTRY-390 > URL: https://issues.apache.org/jira/browse/SENTRY-390 > Project: Sentry > Issue Type: Sub-task > Reporter: Dapeng Sun > Assignee: Dapeng Sun > Fix For: 1.5.0 > > Attachments: SENTRY-390.002.patch, SENTRY-390.patch > > > The jira include: > # SENTRY Thrift API changed : > #* We change the field {{TSentryPrivilege privilege}} to {{set privileges}} in {{TAlterSentryRoleGrantPrivilegeRequest}} and {{TAlterSentryRoleRevokePrivilegeRequest}}, The reason is the HIVE GRANT may like {{Grant SELECT (tb1.col1, tb2.col2) on TABLE table1 to role roleName}}, it contains two privileges ({{col1}} and {{col2}}) for SENTRY, to reduce the request API calls, we make it change. > #* Another way to Implement it, maybe add a {{column list}} to {{TSentryPrivilege}}, but it will bring more problems, we know SentryStore has many convert methods between {{TSentryPrivilege}} and {{MSentryPrivilege}}, and query an unique {{MSentryPrivilege}} use {{TSentryPrivilege}} as query condition, so we should make them one-to-one correspondence. > # Change {{SentryStore}} after Thrift API changed > # Change {{SentryPolicyStoreProcessor}} and {{SentryPolicyServiceClient}} after Thrift API changed, include the grant/revoke methods about column privilege > # Change {{Auditlog}} after Thrift API changed -- This message was sent by Atlassian JIRA (v6.3.4#6332)