Return-Path: X-Original-To: apmail-sentry-commits-archive@minotaur.apache.org Delivered-To: apmail-sentry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B761111B8 for ; Wed, 17 Sep 2014 05:44:58 +0000 (UTC) Received: (qmail 59201 invoked by uid 500); 17 Sep 2014 05:44:58 -0000 Delivered-To: apmail-sentry-commits-archive@sentry.apache.org Received: (qmail 59152 invoked by uid 500); 17 Sep 2014 05:44:58 -0000 Mailing-List: contact commits-help@sentry.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sentry.incubator.apache.org Delivered-To: mailing list commits@sentry.incubator.apache.org Received: (qmail 59142 invoked by uid 99); 17 Sep 2014 05:44:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Sep 2014 05:44:58 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 17 Sep 2014 05:44:36 +0000 Received: (qmail 58536 invoked by uid 99); 17 Sep 2014 05:44:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Sep 2014 05:44:34 +0000 Date: Wed, 17 Sep 2014 05:44:34 +0000 (UTC) From: "Prasad Mujumdar (JIRA)" To: commits@sentry.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SENTRY-380) Clean up some grantorPrincipal semantics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SENTRY-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136809#comment-14136809 ] Prasad Mujumdar commented on SENTRY-380: ---------------------------------------- +1 > Clean up some grantorPrincipal semantics > ---------------------------------------- > > Key: SENTRY-380 > URL: https://issues.apache.org/jira/browse/SENTRY-380 > Project: Sentry > Issue Type: Bug > Affects Versions: 1.4.0 > Reporter: Sravya Tirukkovalur > Assignee: Sravya Tirukkovalur > Fix For: 1.5.0 > > Attachments: SENTRY-380.0.patch, SENTRY-380.1.patch, SENTRY-380.2.patch > > > Came from SENTRY-327 review: > - I do not think grantorPrincipal is required for createRole, we should instead pass it for alterSentryRoleGrantPrivilege and alterSentryRoleRevokePrivilege? > - As we pass grantorPrincipal as the user invoking the thrift request(requestorUserName), we may keep it consistent and avoid possibility of passing different requestorUserName and grantorPrincipal by getting rid of grantorPrincipal field in the TSentryPrivilege and TSentryRole? -- This message was sent by Atlassian JIRA (v6.3.4#6332)