Mailing-List: contact commits-help@sentry.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sentry.incubator.apache.org
Date: Sat, 13 Sep 2014 16:36:34 +0000 (UTC)
From: "Prasad Mujumdar (JIRA)" <jira@apache.org>
To: commits@sentry.incubator.apache.org
Message-ID: <JIRA.12726679.1405025131000.27658.1410626194251@Atlassian.JIRA>
In-Reply-To: <JIRA.12726679.1405025131000@Atlassian.JIRA>
References: <JIRA.12726679.1405025131000@Atlassian.JIRA>
 <JIRA.12726679.1405025131162@arcas>
Subject: [jira] [Commented] (SENTRY-330) Update Derby schema script to
 enforce non-null constraint
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SENTRY-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132818#comment-14132818 ] 

Prasad Mujumdar commented on SENTRY-330:
----------------------------------------

[~skyapus@yahoo.com] The patch itself look fine. The problem I think is about testing the change. The unit tests create the backend schema via dataNucleus and not by running the schema script.
Would it be possible for you to verify the sentry service behavior with schema created using the scripts ? Perhaps a some new test cases that creates the schema using schemaTool first ?


> Update Derby schema script to enforce non-null constraint
> ---------------------------------------------------------
>
>                 Key: SENTRY-330
>                 URL: https://issues.apache.org/jira/browse/SENTRY-330
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Prasad Mujumdar
>            Assignee: Ruiming Zhou
>              Labels: newbie
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-330.patch
>
>
> Currently Derby schema script is not consistent with setting bunch of columns as non-null. We need to keep this in sync with other schema scripts. Since derby is used for unit test, this can cause issues to got through unit tests and fail in the real deployments.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)