sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar (JIRA)" <>
Subject [jira] [Commented] (SENTRY-396) The Thrift multiplexedProcessor registers mutil processor failed
Date Sat, 13 Sep 2014 16:31:33 GMT


Prasad Mujumdar commented on SENTRY-396:

I guess the registeredProcessor is just keeping track if any of the processors failed to register.
It's only used after all the registration is completed to raise an error in case of an error.
The proposed patch would just suppress the error altogether. 
It might make sense to raise the error right away rather than going through the entire list

> The Thrift multiplexedProcessor registers mutil processor failed
> ----------------------------------------------------------------
>                 Key: SENTRY-396
>                 URL:
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: guoquanshen
>            Assignee: guoquanshen
>             Fix For: 1.5.0
>         Attachments: SENTRY-396.patch
> The sentry service uses multiplexedProcessor to register multi processor, but the logic
isn't correct in my opinion. It use processFactory to register and the source code as following:
> {code}TMultiplexedProcessor processor = new TMultiplexedProcessor();
> boolean registeredProcessor = false;
> for (String processorFactory : processorFactories){
>     ProcessorFactory factory = (ProcessorFactory) #create factory instance with processorFactory
> 	registeredProcessor = registeredProcessor || factory.register(processor);
> }{code}
> If the first factory register successfully, registeredProcessor will become true then
the following factories don't get the chance to register

This message was sent by Atlassian JIRA

View raw message