sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sravya Tirukkovalur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-380) Clean up some grantorPrincipal semantics
Date Fri, 19 Sep 2014 17:26:36 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140919#comment-14140919
] 

Sravya Tirukkovalur commented on SENTRY-380:
--------------------------------------------

Hi Dapeng, Sentry-448 has a follow on patch. We will need to keep this required field in thrift
to maintain backward compatibility.

> Clean up some grantorPrincipal semantics
> ----------------------------------------
>
>                 Key: SENTRY-380
>                 URL: https://issues.apache.org/jira/browse/SENTRY-380
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.5.0
>
>         Attachments: SENTRY-380.0.patch, SENTRY-380.1.patch, SENTRY-380.2.patch
>
>
> Came from SENTRY-327 review:
> - I do not think grantorPrincipal is required for createRole, we should instead pass
it for alterSentryRoleGrantPrivilege and alterSentryRoleRevokePrivilege?
> - As we pass grantorPrincipal as the user invoking the thrift request(requestorUserName),
we may keep it consistent and avoid possibility of passing different requestorUserName and
grantorPrincipal by getting rid of grantorPrincipal field in the TSentryPrivilege and TSentryRole?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message