santuario-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Base64 error?
Date Mon, 30 May 2016 10:30:24 GMT
Hi,

I'm doing some testing with various BASE-64 implementations and I think
there's an error in the Santuario Base64 encoder to do with whitespace. If
so though it's been there a looong time without anyone noticing...

The BASE64 implementation is here:

https://svn.apache.org/repos/asf/santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/utils/Base64.java

In the "encode" method it's adding a newline character with:

encodedData[encodedIndex++] = 0xa;

However this is just "\n". The RFC defines a CRLF as "\r\n":

https://www.ietf.org/rfc/rfc2045.txt

It looks like a bug...but would like some feedback from others more
familiar with the RFC.

Colm.


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Mime
View raw message