Mailing-List: contact dev-help@santuario.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@santuario.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <5399AF8C.30409@primekey.se>
Date: Thu, 12 Jun 2014 15:47:56 +0200
From: =?UTF-8?B?TWFya3VzIEtpbMOlcw==?= <markus@primekey.se>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: dev@santuario.apache.org
Subject: Re: Patch performance regression as signature data is not buffered
References: <53999FE6.8070303@primekey.se>
 <CAB8XdGAxuUp1xLecmSW_D5wrjwLPLAkT9L_0=dU3HcronXh4tg@mail.gmail.com>
In-Reply-To: 
 <CAB8XdGAxuUp1xLecmSW_D5wrjwLPLAkT9L_0=dU3HcronXh4tg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

No problem, here you go:
https://issues.apache.org/jira/browse/SANTUARIO-393

Cheers,
Markus

On 2014-06-12 15:38, Colm O hEigeartaigh wrote:
> 
> Could you create a new JIRA here + attach the patch to it?
> 
> https://issues.apache.org/jira/browse/SANTUARIO
> 
> Colm.
> 
> 
> On Thu, Jun 12, 2014 at 1:41 PM, Markus Kilås <markus@primekey.se
> <mailto:markus@primekey.se>> wrote:
> 
>     Hi,
> 
>     After upgrading from xmlsec (java) 1.4 to 1.5 we saw a significant drop
>     in signature generation performance especially when using a network
>     based HSM.
> 
>     After some investigation it turns out that the problem is that the
>     hashing is done with one byte at a time which with network latencies
>     gives the bad performance.
> 
>     Looking in the code of DOMSignedInfo.java it looks like the code intends
>     to use an UnsyncBufferedOutputStream however only its close method is
>     actually called, which as far as I can see won't have any side affect at
>     all when operated on a ByteArrayOutputStream.
> 
>     The attached patch resolves the performance issue by actually using the
>     UnsyncBufferedOutputStream and that way perform the digests on a
>     possibly full buffer instead of byte by byte. The patch has been tested
>     on version 1.5.5 but also applies on 1.5.6.
> 
> 
>     Downstream ticket in SignServer:
>     https://jira.primekey.se/browse/DSS-698
> 
>     --
>     Kind regards,
>     Markus Kilås
>     PrimeKey Solutions
> 
> 
> 
> 
> -- 
> Colm O hEigeartaigh
> 
> Talend Community Coder
> http://coders.talend.com


-- 
Kind regards,
Markus Kilås
PKI Specialist

PrimeKey Solutions AB

Anderstorpsv. 16
171 54 Solna
Sweden

Phone: +46 70 424 94 85
Skype: markusatskype
Email: markus.kilas@primekey.se

www.primekey.se