santuario-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From George Stanchev <Gstanc...@serena.com>
Subject RE: small bug
Date Mon, 16 May 2011 17:23:16 GMT
I'm having some troubles checking out the trunk: getting error [1]. Looking at [2] I see the
following file: "index.html?C=D;O=A". Is there any way to get around this?

[1] svn: Can't open file 'trunk\samples\data\org\w3c\www\interop\xmldsig11\sun\.svn\tmp\text-base\index.html?C=D;O=A.svn-base':
The filename, directory name, or volume label syntax is incorrect.
[2] https://svn.apache.org/repos/asf/santuario/xml-security-java/trunk/samples/data/org/w3c/www/interop/xmldsig11/sun/

-----Original Message-----
From: Colm O hEigeartaigh [mailto:coheigea@apache.org] 
Sent: Friday, May 13, 2011 8:40 AM
To: George Stanchev
Cc: dev@santuario.apache.org
Subject: Re: small bug

It should be fixed on the trunk as well. Could you check to see if
your checkout is up to date?

Colm.

On Fri, May 13, 2011 at 3:36 PM, George Stanchev <Gstanchev@serena.com> wrote:
> Thanks Colm, I was looking at the trunk.
>
>
>
> -----Original Message-----
> From: Colm O hEigeartaigh [mailto:coheigea@apache.org]
> Sent: Friday, May 13, 2011 2:53 AM
> To: dev@santuario.apache.org
> Subject: Re: small bug
>
> This has already been fixed as part of SANTUARIO-262:
>
> https://issues.apache.org/jira/browse/SANTUARIO-262
>
> Colm.
>
> On Fri, May 13, 2011 at 3:50 AM, Giedrius Noreikis
> <giedrius.noreikis@gmail.com> wrote:
>> And why did you change your mind so quickly? :)
>>
>> The statement that getBytes() uses platform's default charset is absolutely
>> correct. It's by design (and a bad one).
>> From this follows that
>>
>> "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n".getBytes()
>>
>> will produce different results on different platforms - as designed and
>> documented.
>>
>> Since the string above contains characters from the first half of ASCII
>> table only, the result will be the same for most encodings - but not for
>> all, of course ;)
>> Trivial examples are encodings using more that one byte to represent a
>> character (e.g. UTF-16, UTF-32). Another nice example is a good old EBCDIC,
>> which is rather different from ASCII :) And yes, it's still used - Java
>> running on z/OS will use EBCDIC as the platform's default :)
>>
>> Giedrius
>>
>>
>> On 2011.05.13 02:17, George Stanchev wrote:
>>
>> And I am a duh.just reread my email. Please disregard it. Totally non-issue.
>>
>>
>>
>> From: George Stanchev [mailto:Gstanchev@serena.com]
>> Sent: Thursday, May 12, 2011 3:59 PM
>> To: dev@santuario.apache.org
>> Subject: small bug
>>
>>
>>
>> Hi,
>>
>>
>>
>> This a small bug I ran into while browsing the source for something else.
>> Not sure if it deserves a JIRA even (let me know and I will submit one if
>> needed)
>>
>>
>>
>> In \src\main\java\org\apache\xml\security\utils\XMLUtils.java there is the
>> following snippet:
>>
>>
>>
>> public static void outputDOM(Node contextNode, OutputStream os,
>>
>>                                 boolean addPreamble)
{
>>
>>
>>
>>       try {
>>
>>          if (addPreamble) {
>>
>>             os.write("<?xml version=\"1.0\"
>> encoding=\"UTF-8\"?>\n".getBytes());
>>
>>          }
>>
>>
>>
>> getBytes() is used which returns the platform encoding but the output XML is
>> specified as UTF-8. Therefore .getBytes("UTF-8") should be used.
>>
>>
>>
>> Since this has been in the code forever and encryption or signature nodes
>> are (probably) all standard 7 bit ASCII, this is not a big deal but it's
>> nice to put the correct code in it when someone from the devs is doing a
>> commit.
>>
>>
>>
>> George
>
>
>



Mime
View raw message