santuario-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Keeping <j...@metanate.com>
Subject Re: [PATCH] xml-security-c: Potential bug in canonicalization from an XPathNodeList
Date Thu, 11 Jun 2009 15:18:03 GMT
Scott Cantor wrote:
> Can you please file all of that in the bugzilla?

Filed as bug 47353 (as you've probably seen!)

> I'm very reluctant to make changes to that code because I don't understand
> it, and don't have any easy way to run any regressions using test vectors,
> but I'll take a look at it.
> 
> One question, is this just Enveloped by itself, or is any actual use of
> XPath required (i.e. building with Xalan?)

We are building with Xalan, but in this case I don't think it's invoked
since XSEC_USE_XPATH_ENVELOPE is not defined, so
DSIGTransformEnvelope::appendTransformer is creating a TXFMEnvelope
rather than a TXFMXPath. Also, the node is found via a URI reference not
an XPath.


John


-- 
John Keeping
+44 (0) 1223 566730 (Direct)
Metanate Ltd, Station Court, Great Shelford, Cambridge CB22 5NE, UK
www.metanate.com (Software consultancy)
www.schemus.com (Data synchronisation)

This e-mail and all attachments it may contain is confidential and
intended solely for the use of the individual to whom it is addressed.
Any views or opinions presented are those of the author and do not
necessarily represent those of Metanate Ltd.  If you are not the
intended recipient, be advised that you have received this e-mail in
error and that any use, dissemination, printing, forwarding or copying
of this e-mail is strictly prohibited.  Please contact the sender if
you have received this e-mail in error.


Mime
View raw message