santuario-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40512] - Fix incompatible API changes to TransformSpi
Date Thu, 14 Sep 2006 15:22:39 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40512>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40512





------- Additional Comments From raul-info@r-bg.com  2006-09-14 15:22 -------
Sorry for the delay too much daily work.
For me the better is the 4. Document it and let the people work.

The point 3 can be done but the solution is slightly different and can be slow.
The change comes because of the thread issues and the "slowness" of
newInstance() method. Before the change we create a transform object for every
signature to process. After the change we create only a stateless object and
reuse in all transformations. 

Your solution can change slightly with(I have no compiler here so take it with a
grain of salt).

try {
  result = transformSpi.enginePerformTransform(input,this);
} catch (UnsupportedOperationException ex) {
  TransformSpi newTransformSpi=transformSpi.class.newInstance();
  newTransformSpi.setTransfor(this);
  result = newTransformSpi.enginePerformTransform(input);
}

What do you think?

The only main problem with your solution is that when someone want to create a
Transform the compiler will not force to implement any method.

If there is enough push for the 3. I will implement this. But I still think it
should be better to document the change.

Regards,
Raul

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Mime
View raw message