Mailing-List: contact security-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: security-dev@xml.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: [C++] Memory Leak In DSIGSignature::verify() using RSA Signatures
 with WINCAPI
Date: Fri, 14 Oct 2005 16:46:21 +0100
Message-ID: 
 <4F014656062C1140880B2247EDAFD3B101068365@ukspm204.emea.corp.eds.com>
Thread-Topic: [C++] Memory Leak In DSIGSignature::verify() using RSA
 Signatures with WINCAPI
Thread-Index: AcXPMuSRzY/2sH68R4C3Z1UQsAr/AgBb8lpAAAdmyTAABSSJEA==
From: "Cullum, Steve" <steven.cullum@eds.com>
To: <security-dev@xml.apache.org>

I am having real trouble tracking down a memory leak when using RSA
certificates via the MSCrypto interface.  I have already fixed one error
in the WinCAPICryptoKeyRSA() destructor.. (see previous thread).  But
memory is still being leaked when DSIGSignature::verify() gets called.

Steps used .. To reproduce behaviour are simple=20

A) I Load a document digitally signed by RSA private key
B) Install the certificate into the Windows key store
C) Use the WINCAPI interface to load the certificate

The leak happens when DSIGSignature::verify() is called.  It does not
matter verification is successful or not. I can provide a test driver
and source to reproduce the behaviour.

Has anybody got any ideas ... ?  Where to look next.

I am using the very latest version of XSEC (dloaded from CVS on the 14th
Oct 05)


// change ~WinCAPICryptoKeyRSA and comment out the sig->verify() and no
leaks occur
// uncomment out sig->verify() and memory is leaked

    XercesDOMParser parser;
    parser.setDoNamespaces(true);
    parser.setCreateEntityReferenceNodes(true);
    parser.setDoSchema(true);
=20
    MemBufInputSource *memIS =3D new MemBufInputSource((const XMLByte
*)buffer, bufferLen, "XSECMem", false);
    parser.parse(*memIS);
    delete memIS;   // destroy as soon as possible

    if(parser.getErrorCount() > 0)=20
	exit(1);
=20
    // Now create a signature object to validate the document
    XSECProvider prov;
    DSIGSignature *sig =3D =
prov.newSignatureFromDOM(parser.getDocument());

    sig->registerIdAttributeName(config.idAttributeName);
    sig->registerIdAttributeNameNS(config.idAttributeNS,
config.idAttributeName);
    sig->load(); =20

    XSECCryptoKey *clone =3D X509->clonePublicKey();=20
    sig->setSigningKey(clone);
 =20
    sig->verify();		// leak here.. With the
WinCAPICryptoKeyRSA::~WinCAPICryptoKeyRSA() fix in place=20
					// commenting out sig->verify()
stops leaks.=20
   =20

    prov.releaseSignature(sig);