samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prateekm <...@git.apache.org>
Subject [GitHub] samza pull request #113: SAMZA-1191: Fixed flaky test: TestExponentialSleepS...
Date Thu, 06 Apr 2017 01:33:23 GMT
GitHub user prateekm opened a pull request:

    https://github.com/apache/samza/pull/113

    SAMZA-1191: Fixed flaky test: TestExponentialSleepStrategy testThreadInterruptInRetryLoop

    It's possible that the interruptee thread (see `#interruptedThread`) gets pre-empted before
it has a chance to run the operation (increment `iterations`) and then gets interrupted, causing
these assertions to fail.
    
    I think these assertions also aren't critical for the tests which I presume want to test
interrupt propagation behavior, so removing them in this change.
    
    @vjagadish1989 & @xinyuiscool, please take a look.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prateekm/samza flaky-ess-test-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit 802d6a913d729b9fe4427fde81683bbaca401d1c
Author: Prateek Maheshwari <pmaheshw@linkedin.com>
Date:   2017-04-06T01:08:12Z

    SAMZA-1191: Fixed flaky test: TestExponentialSleepStrategy testThreadInterruptInRetryLoop

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message