Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A5F31200BC5 for ; Tue, 22 Nov 2016 19:51:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A486C160B0C; Tue, 22 Nov 2016 18:51:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EDF24160AF1 for ; Tue, 22 Nov 2016 19:51:08 +0100 (CET) Received: (qmail 46126 invoked by uid 500); 22 Nov 2016 18:51:08 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 46090 invoked by uid 99); 22 Nov 2016 18:51:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 18:51:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 65CEA2F5AB2; Tue, 22 Nov 2016 18:51:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6728963742221895348==" MIME-Version: 1.0 Subject: Re: Review Request 53826: added user document for Checkpoint callbacks From: Prateek Maheshwari To: Boris Shkolnik , samza Date: Tue, 22 Nov 2016 18:51:06 -0000 Message-ID: <20161122185106.27387.52217@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Prateek Maheshwari X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53826/ X-Sender: Prateek Maheshwari X-ReviewBoard-ShipIt: 1 References: <20161119005250.20484.90044@reviews.apache.org> In-Reply-To: <20161119005250.20484.90044@reviews.apache.org> Reply-To: Prateek Maheshwari X-ReviewRequest-Repository: samza archived-at: Tue, 22 Nov 2016 18:51:09 -0000 --===============6728963742221895348== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156607 ----------------------------------------------------------- Ship it! Looks good. Minor comments. docs/learn/documentation/versioned/container/checkpointing.md (line 126) Can be moved to previous line. docs/learn/documentation/versioned/container/checkpointing.md (line 129) What does the "push system" mean? Maybe clarify/remove? docs/learn/documentation/versioned/container/checkpointing.md (line 138) Multiple "and"s in the sentence. Maybe "... for a task. These are the ..."? - Prateek Maheshwari On Nov. 18, 2016, 4:52 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53826/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 4:52 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1046 > https://issues.apache.org/jira/browse/SAMZA-1046 > > > Repository: samza > > > Description > ------- > > added user documentation for Checkpoint callbacks > > > Diffs > ----- > > docs/learn/documentation/versioned/container/checkpointing.md 6f8c6d694be92f973af456ddd518d70540abe5c3 > > Diff: https://reviews.apache.org/r/53826/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > > --===============6728963742221895348==--