Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C909E200BBB for ; Thu, 10 Nov 2016 19:53:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C79C9160B01; Thu, 10 Nov 2016 18:53:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 219CC160AF7 for ; Thu, 10 Nov 2016 19:53:10 +0100 (CET) Received: (qmail 80733 invoked by uid 500); 10 Nov 2016 18:53:10 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 80712 invoked by uid 99); 10 Nov 2016 18:53:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 18:53:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A4B3A25BF59; Thu, 10 Nov 2016 18:53:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2048657954891054340==" MIME-Version: 1.0 Subject: Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications From: Boris Shkolnik To: Prateek Maheshwari , Navina Ramesh , Boris Shkolnik , samza Date: Thu, 10 Nov 2016 18:53:09 -0000 Message-ID: <20161110185309.1691.14095@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Boris Shkolnik X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53453/ X-Sender: Boris Shkolnik References: <20161109204833.4231.53596@reviews.apache.org> In-Reply-To: <20161109204833.4231.53596@reviews.apache.org> X-ReviewBoard-Diff-For: samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointListener.java Reply-To: Boris Shkolnik X-ReviewRequest-Repository: samza archived-at: Thu, 10 Nov 2016 18:53:12 -0000 --===============2048657954891054340== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 9, 2016, 8:48 p.m., Navina Ramesh wrote: > > Is there any practical implementation of this interface . eg. adding to kafkasystemconsumer? Or is it expected in the future? I have used it with LiKafka for manual testing, but nothing to check in.. - Boris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/#review155495 ----------------------------------------------------------- On Nov. 4, 2016, 11:23 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53453/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 11:23 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1042 > https://issues.apache.org/jira/browse/SAMZA-1042 > > > Repository: samza > > > Description > ------- > > Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications. > > > Diffs > ----- > > samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointListener.java PRE-CREATION > samza-api/src/main/java/org/apache/samza/system/SystemConsumer.java 8dfcc7499659442aabd3085a8787475fe38f29db > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala c41eadb70f4675816245f7ac40f0db2fc16335f0 > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala e0468ee89c89fd720834461771ebb36475475bcb > samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala cb78223f1b59a78bbeb1e42b5974670a53def504 > > Diff: https://reviews.apache.org/r/53453/diff/ > > > Testing > ------- > > gradlew test. > manual testing. > > > Thanks, > > Boris Shkolnik > > --===============2048657954891054340==--