Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89F1F200BCB for ; Thu, 10 Nov 2016 02:04:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 88831160AFD; Thu, 10 Nov 2016 01:04:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CE188160AFA for ; Thu, 10 Nov 2016 02:04:11 +0100 (CET) Received: (qmail 67767 invoked by uid 500); 10 Nov 2016 01:04:11 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 66918 invoked by uid 99); 10 Nov 2016 01:04:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 01:04:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AF20E2DDAAB; Thu, 10 Nov 2016 01:04:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3622969397670412818==" MIME-Version: 1.0 Subject: Re: Review Request 53297: Initial version of adding metrics into samza rest. From: Shanthoosh Venkataraman To: Jake Maes Cc: Jagadish Venkatraman , Prateek Maheshwari , Shanthoosh Venkataraman , samza Date: Thu, 10 Nov 2016 01:04:08 -0000 Message-ID: <20161110010408.4231.56168@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Shanthoosh Venkataraman X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53297/ X-Sender: Shanthoosh Venkataraman References: <20161110000437.4231.65892@reviews.apache.org> In-Reply-To: <20161110000437.4231.65892@reviews.apache.org> X-ReviewBoard-Diff-For: samza-rest/src/test/java/org/apache/samza/rest/TestSamzaRestService.java X-ReviewBoard-Diff-For: samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java Reply-To: Shanthoosh Venkataraman X-ReviewRequest-Repository: samza archived-at: Thu, 10 Nov 2016 01:04:12 -0000 --===============3622969397670412818== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/ ----------------------------------------------------------- (Updated Nov. 10, 2016, 1:04 a.m.) Review request for samza and Jake Maes. Repository: samza Description ------- This patch aims at enabling users to define custom reporters to send metrics from the monitors. Configurations required for the definition of the metrics reporters follows the same convention as of the samza jobs. Diffs (updated) ----- docs/learn/documentation/versioned/rest/monitors.md 46678bbe5fed99f767c3324dc9578ee1a64cec66 samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java PRE-CREATION samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala e0468ee89c89fd720834461771ebb36475475bcb samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala f24beb1e099dd44b15b475e0a4a7f70560c6965e samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 47b0663637f6db187d86961377ee3ee203b73fdb samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java 2a3e83a24a5343bb53b93fc9d0a647c1b253714b samza-rest/src/test/java/org/apache/samza/rest/TestSamzaRestService.java PRE-CREATION samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca Diff: https://reviews.apache.org/r/53297/diff/ Testing ------- Unit tests are done to verify the intended functionality. Thanks, Shanthoosh Venkataraman --===============3622969397670412818==--