samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jagadish Venkatraman <jagadish1...@gmail.com>
Subject Review Request 53392: Initial Implementation of a Session Window
Date Mon, 07 Nov 2016 22:00:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53392/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Simplifying assumptions:
- Aggregations are done based on system time. (So, no notion of late arrivals based on event-time).
Sessions can be expired immediately and emitted.


Diffs
-----

  build.gradle 28c2dcf52b0af33c19b4c99e159fd3a4b71bbf9c 
  checkstyle/import-control.xml 53cb8b447240fea08d98ccfb12ed24bec6cbf67c 
  samza-api/src/main/java/org/apache/samza/operators/TriggerBuilder.java 5b7db9cffe878d5b6ce258c7f38aecb0ca643b79

  samza-api/src/main/java/org/apache/samza/operators/Windows.java 5ffa2116da4301857f4f921ad0ad4cb0e6089fe0

  samza-api/src/main/java/org/apache/samza/operators/internal/Operators.java f06387c9f49592a901ce01d996aa7ae7c95e89e2

  samza-api/src/main/java/org/apache/samza/operators/internal/Trigger.java 3b50e2b8f640851a974ad01bc92425e50319692f

  samza-api/src/test/java/org/apache/samza/operators/TestMessage.java 8c5628757883168ce3f5a324884b967401b615fa

  samza-api/src/test/java/org/apache/samza/operators/data/TestLongOffset.java 943c47f58c6013f213c1761f5c08a3fae0570968

  samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemConsumer.java
e1a7626de9ca78ffbffeab65a69605e748ab4479 
  samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamSystemProducer.java
36cf759e6847d9422d2fdc9d07af9597b2abadc3 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala e3d0b6cb4181e58c1526efecd6fb58cdd69d8fad

  samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala 06a96ad6ed786c22924017f894413bfa1ea34c06

  samza-core/src/test/scala/org/apache/samza/checkpoint/TestCheckpointTool.scala 0865b31fa11c7363c64e167c10077e5a6af1793a

  samza-operator/src/main/java/org/apache/samza/operators/api/data/Data.java 69a3bee2ac3ea22862c958dd2a16e1df42f4ad15

  samza-operator/src/main/java/org/apache/samza/operators/api/data/Schema.java dc3f8f4343d9057391564ab48ee0add912f21f69

  samza-operator/src/main/java/org/apache/samza/operators/impl/ChainedOperators.java 82f3c281e8f494303a999b13213395ca2b36d04a

  samza-operator/src/main/java/org/apache/samza/operators/impl/OrderPreservingKeyValueStore.java
PRE-CREATION 
  samza-operator/src/main/java/org/apache/samza/operators/impl/ProcessorContext.java cc7ef2b97d9dbd50a0bf90d0e8af96c9bd1a12f7

  samza-operator/src/main/java/org/apache/samza/operators/impl/SessionStateStoreImpl.java
PRE-CREATION 
  samza-operator/src/main/java/org/apache/samza/operators/impl/data/avro/AvroData.java e4f5d7974a45e86fafa34ae36965c2234fb174cf

  samza-operator/src/main/java/org/apache/samza/operators/impl/data/avro/AvroSchema.java c04e4f650e62b120268d93a284a133bb08d4aa50

  samza-operator/src/main/java/org/apache/samza/operators/impl/data/serializers/SqlAvroSerde.java
2432aca9d7bdd3d953a49b0fc2ba4effbf4aed9e 
  samza-operator/src/main/java/org/apache/samza/operators/impl/data/serializers/SqlStringSerde.java
1267ab6ce046260212f88721d4eb9650534c069c 
  samza-operator/src/main/java/org/apache/samza/operators/impl/data/serializers/SqlStringSerdeFactory.java
3b6a3e053d925ce9e4edddc656b0029328f3239b 
  samza-operator/src/main/java/org/apache/samza/operators/impl/data/string/StringData.java
86e9917704bff00172c81815c0e061e9931facf7 
  samza-operator/src/main/java/org/apache/samza/operators/impl/data/string/StringSchema.java
b19dfebff248be451bdc1c612d80cd6cfc39e664 
  samza-operator/src/main/java/org/apache/samza/operators/impl/window/SessionWindowImpl.java
0d6141e7acc7224cb7545b9a027729b09fc48489 
  samza-operator/src/main/java/org/apache/samza/task/StreamOperatorAdaptorTask.java 18b077b1ee1430f637a918b835701da93206041f

  samza-operator/src/test/java/org/apache/samza/operators/impl/TestSimpleOperatorImpl.java
69f16d07f25b43131975964483000e02617fbb06 
  samza-operator/src/test/java/org/apache/samza/operators/impl/data/serializers/SqlAvroSerdeTest.java
5aa28bbbb75c7e6efbe6b7ccb066dd47235ee7ca 
  samza-operator/src/test/java/org/apache/samza/operators/impl/window/TestSessionWindowImpl.java
719ab99bfabe0d17c35ce6aefb3b3639e15cf956 
  samza-operator/src/test/java/org/apache/samza/task/TestStreamOperatorAdaptorTask.java 153d517f7055001baa8fed08baf274db06fbdb14


Diff: https://reviews.apache.org/r/53392/diff/


Testing
-------

Added basic Unit tests.

TODO:
More testing, Add an integration test with a sample Samza Job.


Thanks,

Jagadish Venkatraman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message