Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46A70189A3 for ; Fri, 29 Apr 2016 11:14:19 +0000 (UTC) Received: (qmail 69370 invoked by uid 500); 29 Apr 2016 11:14:19 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 69317 invoked by uid 500); 29 Apr 2016 11:14:19 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 69304 invoked by uid 99); 29 Apr 2016 11:14:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Apr 2016 11:14:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7FEDF2B40B3; Fri, 29 Apr 2016 11:14:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7357692890418979842==" MIME-Version: 1.0 Subject: Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil From: Alex Buck To: "Yi Pan \(Data Infrastructure\)" , samza , Alex Buck Date: Fri, 29 Apr 2016 11:14:13 -0000 Message-ID: <20160429111413.26196.68445@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alex Buck X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46732/ X-Sender: Alex Buck References: <20160428172843.26196.99110@reviews.apache.org> In-Reply-To: <20160428172843.26196.99110@reviews.apache.org> X-ReviewBoard-Diff-For: samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json X-ReviewBoard-Diff-For: samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java Reply-To: Alex Buck X-ReviewRequest-Repository: samza --===============7357692890418979842== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 28, 2016, 5:28 p.m., Yi Pan (Data Infrastructure) wrote: > > Hi, @Alex, thanks for the quick update. There is a few more checkstyle failures: > > > > :samza-autoscaling_2.10:checkstyleTest > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:21:1: Disallowed import - org.apache.commons.io.IOUtils. > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:25:8: Unused import - java.util.Arrays. > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:29:1: Disallowed import - org.hamcrest.core.Is.is. > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:34: method def modifier at indentation level 4 not at correct indentation, 2 > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:35: method def modifier at indentation level 4 not at correct indentation, 2 > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:36: method def child at indentation level 8 not at correct indentation, 4 > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:37: method def child at indentation level 8 not at correct indentation, 4 > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:38: method def child at indentation level 8 not at correct indentation, 4 > > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:40: method def rcurly at indentation level 4 not at correct indentation, 2 > > :samza-autoscaling_2.10:checkstyleTest FAILED > > > > Could you help to address them? You can run ./gradlew clean check to re-pro the above errors. Thanks! Hi @Yi i've updated it so the checkstyle tests pass. Hopefully I won't make these mistakes again! Thanks - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review130952 ----------------------------------------------------------- On April 29, 2016, 11:13 a.m., Alex Buck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46732/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 11:13 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > fix issue with json deserialisation in YarnUtil > > > Diffs > ----- > > checkstyle/import-control.xml c15b8e74de8e5aac5ac83278c52ab3dba1630e50 > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java 376c549ededaa04401513752b510a4e6c3a6e386 > samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java PRE-CREATION > samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json PRE-CREATION > > Diff: https://reviews.apache.org/r/46732/diff/ > > > Testing > ------- > > Very open to any feedback especially as it's my first review request for Samza. Thanks > > https://issues.apache.org/jira/browse/SAMZA-930 > > > Thanks, > > Alex Buck > > --===============7357692890418979842==--