samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Buck <alex.buc...@gmail.com>
Subject Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil
Date Fri, 29 Apr 2016 11:14:13 GMT


> On April 28, 2016, 5:28 p.m., Yi Pan (Data Infrastructure) wrote:
> > Hi, @Alex, thanks for the quick update. There is a few more checkstyle failures:
> > 
> > :samza-autoscaling_2.10:checkstyleTest
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:21:1:
Disallowed import - org.apache.commons.io.IOUtils.
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:25:8:
Unused import - java.util.Arrays.
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:29:1:
Disallowed import - org.hamcrest.core.Is.is.
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:34:
method def modifier at indentation level 4 not at correct indentation, 2
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:35:
method def modifier at indentation level 4 not at correct indentation, 2
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:36:
method def child at indentation level 8 not at correct indentation, 4
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:37:
method def child at indentation level 8 not at correct indentation, 4
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:38:
method def child at indentation level 8 not at correct indentation, 4
> > [ant:checkstyle] /home/yipan/workspace/samza_master/samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java:40:
method def rcurly at indentation level 4 not at correct indentation, 2
> > :samza-autoscaling_2.10:checkstyleTest FAILED
> > 
> > Could you help to address them? You can run ./gradlew clean check to re-pro the
above errors. Thanks!

Hi @Yi i've updated it so the checkstyle tests pass. Hopefully I won't make these mistakes
again! Thanks


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46732/#review130952
-----------------------------------------------------------


On April 29, 2016, 11:13 a.m., Alex Buck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46732/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 11:13 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> fix issue with json deserialisation in YarnUtil
> 
> 
> Diffs
> -----
> 
>   checkstyle/import-control.xml c15b8e74de8e5aac5ac83278c52ab3dba1630e50 
>   samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java 376c549ededaa04401513752b510a4e6c3a6e386

>   samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java
PRE-CREATION 
>   samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/46732/diff/
> 
> 
> Testing
> -------
> 
> Very open to any feedback especially as it's my first review request for Samza. Thanks
> 
> https://issues.apache.org/jira/browse/SAMZA-930
> 
> 
> Thanks,
> 
> Alex Buck
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message