samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Buck <alex.buc...@gmail.com>
Subject Re: Review Request 46732: SAMZA-930 fix issue with json deserialisation in YarnUtil
Date Thu, 28 Apr 2016 13:42:06 GMT


> On April 28, 2016, 12:32 a.m., Yi Pan (Data Infrastructure) wrote:
> > samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java,
line 1
> > <https://reviews.apache.org/r/46732/diff/1/?file=1363169#file1363169line1>
> >
> >     Sorry I missed this one in the review. Apache license paragraph is required
at the beginning of each source file. Please copy the license paragraph from any java/scala
file and paste at the beginning of this file.
> >     
> >     Thanks!

Thanks Yi I've now added the license.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46732/#review130871
-----------------------------------------------------------


On April 28, 2016, 1:41 p.m., Alex Buck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46732/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 1:41 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> fix issue with json deserialisation in YarnUtil
> 
> 
> Diffs
> -----
> 
>   samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java 376c549ededaa04401513752b510a4e6c3a6e386

>   samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java
PRE-CREATION 
>   samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/46732/diff/
> 
> 
> Testing
> -------
> 
> Very open to any feedback especially as it's my first review request for Samza. Thanks
> 
> https://issues.apache.org/jira/browse/SAMZA-930
> 
> 
> Thanks,
> 
> Alex Buck
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message