samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boris Shkolnik <bor...@apache.org>
Subject Re: Review Request 46303: SAMZA-935: add functionality to wait for kafka to start
Date Tue, 19 Apr 2016 19:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46303/#review129603
-----------------------------------------------------------


Ship it!




Lgtm! Thanks!

- Boris Shkolnik


On April 19, 2016, 7:39 p.m., Vishal Kuo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46303/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 7:39 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> To prevent kafka dependent services and unit tests to fail intermittently after bootstrap,
a wait_kafka function has been added
> 
> 
> Diffs
> -----
> 
>   bin/grid 042cabe355ec3a8fff06f193252fec494d01a864 
> 
> Diff: https://reviews.apache.org/r/46303/diff/
> 
> 
> Testing
> -------
> 
> * Tested normal bootstrap procedure works with additional wait added for kafka
> * Tested that timeout occurs if Kafka takes too long to start
> 
> 
> Thanks,
> 
> Vishal Kuo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message