Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4AE3B1768D for ; Fri, 22 Jan 2016 06:39:00 +0000 (UTC) Received: (qmail 56337 invoked by uid 500); 22 Jan 2016 06:39:00 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 56277 invoked by uid 500); 22 Jan 2016 06:39:00 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 56260 invoked by uid 99); 22 Jan 2016 06:38:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 06:38:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 673DC282E0D; Fri, 22 Jan 2016 06:38:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3886943259921848003==" MIME-Version: 1.0 Subject: Re: Review Request 42619: move public kv api from samza-kv to samza-api package From: "Jagadish Venkatraman" To: "Boris Shkolnik" , "Jagadish Venkatraman" , "samza" Date: Fri, 22 Jan 2016 06:38:58 -0000 Message-ID: <20160122063858.32038.57991@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jagadish Venkatraman" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42619/ X-Sender: "Jagadish Venkatraman" References: <20160121222715.32038.97690@reviews.apache.org> In-Reply-To: <20160121222715.32038.97690@reviews.apache.org> Reply-To: "Jagadish Venkatraman" X-ReviewRequest-Repository: samza --===============3886943259921848003== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42619/#review115794 ----------------------------------------------------------- Ship it! LGTM - Jagadish Venkatraman On Jan. 21, 2016, 10:27 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42619/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 10:27 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-861 > https://issues.apache.org/jira/browse/SAMZA-861 > > > Repository: samza > > > Description > ------- > > move public kv api from samza-kv to samza-api package > > > Diffs > ----- > > samza-kv/src/main/java/org/apache/samza/storage/kv/Entry.java > samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueIterator.java > samza-kv/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java > > Diff: https://reviews.apache.org/r/42619/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > > --===============3886943259921848003==--