Return-Path: 
 <dev-return-5007-apmail-samza-dev-archive=samza.apache.org@samza.apache.org>
X-Original-To: apmail-samza-dev-archive@minotaur.apache.org
Delivered-To: apmail-samza-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E2F7E18E5A
	for <apmail-samza-dev-archive@minotaur.apache.org>;
 Tue, 24 Nov 2015 02:33:52 +0000 (UTC)
Received: (qmail 63604 invoked by uid 500); 24 Nov 2015 02:33:52 -0000
Delivered-To: apmail-samza-dev-archive@samza.apache.org
Received: (qmail 63550 invoked by uid 500); 24 Nov 2015 02:33:52 -0000
Mailing-List: contact dev-help@samza.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@samza.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@samza.apache.org>
List-Post: <mailto:dev@samza.apache.org>
List-Id: <dev.samza.apache.org>
Reply-To: dev@samza.apache.org
Delivered-To: mailing list dev@samza.apache.org
Received: (qmail 63389 invoked by uid 99); 24 Nov 2015 02:33:52 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 02:33:52 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 4D3ED2E391C;
	Tue, 24 Nov 2015 02:33:50 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7782892683743824237=="
MIME-Version: 1.0
Subject: Re: Review Request 40572: SAMZA-614 - Document coordinator stream
From: "Navina Ramesh" <nramesh@linkedin.com>
To: "Boris Shkolnik" <boryas@apache.org>,
 "Chris Riccomini" <criccomini@apache.org>, "Xinyu Liu" <xiliu@linkedin.com>,
 "Yan Fang" <yanfang724@gmail.com>,
 "Yi Pan (Data Infrastructure)" <yipan@linkedin.com>,
 "Jagadish Venkatraman" <jagadish1989@gmail.com>
Cc: "Navina Ramesh" <nramesh@linkedin.com>, "samza" <dev@samza.apache.org>
Date: Tue, 24 Nov 2015 02:33:50 -0000
Message-ID: <20151124023350.26797.42259@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Navina Ramesh" <noreply@reviews.apache.org>
X-ReviewGroup: Samza
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/40572/
X-Sender: "Navina Ramesh" <noreply@reviews.apache.org>
References: <20151123193156.26798.43402@reviews.apache.org>
In-Reply-To: <20151123193156.26798.43402@reviews.apache.org>
Reply-To: "Navina Ramesh" <nramesh@linkedin.com>
X-ReviewRequest-Repository: samza

--===============7782892683743824237==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On Nov. 23, 2015, 7:31 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/learn/documentation/versioned/container/coordinator-stream.md, line 95
> > <https://reviews.apache.org/r/40572/diff/2/?file=1135547#file1135547line95>
> >
> >     Just to make it consistent w/ set-changelog and set-container-host-assignment, shouldn't this be:
> >     {code}
> >     <td> 'value' => &lt;config-value&gt; </td>
> >     {code}

My bad. Fixed it.


> On Nov. 23, 2015, 7:31 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/learn/documentation/versioned/container/coordinator-stream.md, line 130
> > <https://reviews.apache.org/r/40572/diff/2/?file=1135547#file1135547line130>
> >
> >     Prefer to say "HTTP API"

I changed it "an HTTP service". I am not sure if API is the right usage. Let me know if I am mistaken.


> On Nov. 23, 2015, 7:31 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/learn/documentation/versioned/container/coordinator-stream.md, line 137
> > <https://reviews.apache.org/r/40572/diff/2/?file=1135547#file1135547line137>
> >
> >     Is this true as for today? I thought that in today's YARN job deployment, when AppMaster is down, the whole job is restarted (i.e. the containers will be shutdown and restarted as well). The description here is more like a "want-to-be" state, not the current state.

This is talking about the JC itself, rather than the AM. When AM is restarted, all the containers should get restarted. I think first sentence is referring to a scenarios with Yarn High Availability. Should I just mention that JC availability is same as the AM's availability since JC resides within the AM? I can additionally mention how this will work with Yarn HA.


> On Nov. 23, 2015, 7:31 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/learn/documentation/versioned/container/coordinator-stream.md, line 147
> > <https://reviews.apache.org/r/40572/diff/2/?file=1135547#file1135547line147>
> >
> >     One more benifit that would be huge to add to 5:
> >     - enables future design of JobCoordinator fail-over since it serves as the single source of truth of current Job state.

Are you referring to the failover of the Job Coordinator or the failover of containers??


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40572/#review107623
-----------------------------------------------------------


On Nov. 23, 2015, 3:38 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40572/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 3:38 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-614
>     https://issues.apache.org/jira/browse/SAMZA-614
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-614 - Document coordinator stream
> Updated configuration-table.html
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/container/coordinator-stream.md PRE-CREATION 
>   docs/learn/documentation/versioned/container/serialization.md 6bcb641f2e3d168581274e468746f9f3078d4b8a 
>   docs/learn/documentation/versioned/index.html dec5be15453a8e5794a9c66b0010803f591ed0cf 
>   docs/learn/documentation/versioned/jobs/configuration-table.html b5d3813ab44062f61cb33e4b37bb7548d8ff0617 
> 
> Diff: https://reviews.apache.org/r/40572/diff/
> 
> 
> Testing
> -------
> 
> Locally tested the site
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


--===============7782892683743824237==--