Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0D7218E29 for ; Wed, 18 Nov 2015 21:24:56 +0000 (UTC) Received: (qmail 89440 invoked by uid 500); 18 Nov 2015 21:24:56 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 89378 invoked by uid 500); 18 Nov 2015 21:24:56 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 89357 invoked by uid 99); 18 Nov 2015 21:24:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2015 21:24:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 84424290844; Wed, 18 Nov 2015 21:24:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8924855313063434465==" MIME-Version: 1.0 Subject: Re: Review Request 40421: SAMZA-754: fix the null oldestOffset issue in empty topics From: "Navina Ramesh" To: "Yan Fang" , "Navina Ramesh" , "Chris Riccomini" , "Chinmay Soman" Cc: "samza" , "Yi Pan (Data Infrastructure)" Date: Wed, 18 Nov 2015 21:24:55 -0000 Message-ID: <20151118212455.19610.6014@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Navina Ramesh" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40421/ X-Sender: "Navina Ramesh" References: <20151118013003.6715.22980@reviews.apache.org> In-Reply-To: <20151118013003.6715.22980@reviews.apache.org> Reply-To: "Navina Ramesh" X-ReviewRequest-Repository: samza --===============8924855313063434465== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40421/#review107088 ----------------------------------------------------------- Ship it! One question. Otherwise, lgtm! :) samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala (line 198) Should we do a similar check for newestOffsets? - Navina Ramesh On Nov. 18, 2015, 1:30 a.m., Yi Pan (Data Infrastructure) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40421/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 1:30 a.m.) > > > Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Navina Ramesh. > > > Bugs: SAMZA-754 > https://issues.apache.org/jira/browse/SAMZA-754 > > > Repository: samza > > > Description > ------- > > SAMZA-754: fix the null oldestOffset issue in empty topics > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala aee33a92941dcf686eed3fcfe7bc8ca01b1ac88b > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala d260f2d776f567a19cb470100f7c3dc659df690d > samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala 6e260bdd14f116fcb05c02f085ca1287bcd9f2ad > > Diff: https://reviews.apache.org/r/40421/diff/ > > > Testing > ------- > > Unit test updated and passed. > > > Thanks, > > Yi Pan (Data Infrastructure) > > --===============8924855313063434465==--