samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tommy Becker" <twbec...@gmail.com>
Subject Review Request 40106: SAMZA-812 CachedStore flushes too often
Date Mon, 09 Nov 2015 21:30:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40106/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-812
    https://issues.apache.org/jira/browse/SAMZA-812


Repository: samza


Description
-------

Fix for SAMZA-812. Only flush CachedStore when necessary, with the exception that this preserves
the buggy flush behavior for array keys. Otherwise the store will not behave properly for
array keys due to the mismatch between the reference semantics of the cache vs the value semantics
of the store. See the bug for details.


Diffs
-----

  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 1112350 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala cc9c9f3 

Diff: https://reviews.apache.org/r/40106/diff/


Testing
-------

Unit tested


Thanks,

Tommy Becker


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message