Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F277F1870E for ; Wed, 19 Aug 2015 05:05:17 +0000 (UTC) Received: (qmail 88086 invoked by uid 500); 19 Aug 2015 05:05:17 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 88031 invoked by uid 500); 19 Aug 2015 05:05:17 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 88010 invoked by uid 99); 19 Aug 2015 05:05:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 05:05:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDC14D5335; Wed, 19 Aug 2015 05:05:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5183440464233759735==" MIME-Version: 1.0 Subject: Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME From: "Yan Fang" To: "Yan Fang" , "Aleksandar Pejakovic" , "samza" Date: Wed, 19 Aug 2015 05:05:16 -0000 Message-ID: <20150819050516.1535.93904@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yan Fang" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37528/ X-Sender: "Yan Fang" References: <20150818125845.1535.9041@reviews.apache.org> In-Reply-To: <20150818125845.1535.9041@reviews.apache.org> Reply-To: "Yan Fang" X-ReviewRequest-Repository: samza --===============5183440464233759735== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37528/#review95817 ----------------------------------------------------------- samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala (lines 163 - 164) will this stop the Container, or just log the error and finish this thread? If we want to stop the Container, I think we need to throw a SamzaException here. samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala (line 46) why is the order changed? samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala (line 366) this test seems not testing anything. :) - Yan Fang On Aug. 18, 2015, 12:58 p.m., Aleksandar Pejakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37528/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 12:58 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Added new catch blocks to prevent infinite loops > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277 > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec > > Diff: https://reviews.apache.org/r/37528/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandar Pejakovic > > --===============5183440464233759735==--