Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B8C818CBA for ; Thu, 13 Aug 2015 01:16:33 +0000 (UTC) Received: (qmail 72235 invoked by uid 500); 13 Aug 2015 01:16:33 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 72177 invoked by uid 500); 13 Aug 2015 01:16:33 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 72157 invoked by uid 99); 13 Aug 2015 01:16:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Aug 2015 01:16:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 763E4DC829; Thu, 13 Aug 2015 01:16:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6508240592247255656==" MIME-Version: 1.0 Subject: Review Request 37428: SAMZA-723: hello-samza hangs when using StreamAppender From: "Yan Fang" To: "Yan Fang" , "samza" Date: Thu, 13 Aug 2015 01:16:29 -0000 Message-ID: <20150813011629.30461.4327@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yan Fang" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37428/ X-Sender: "Yan Fang" Reply-To: "Yan Fang" X-ReviewRequest-Repository: samza --===============6508240592247255656== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37428/ ----------------------------------------------------------- Review request for samza. Bugs: SAMZA-723 https://issues.apache.org/jira/browse/SAMZA-723 Repository: samza Description ------- fixed 2 parts of the problem: 1. Start streamAppender until the JobCoordinator is running 2. deadlock in Producer thread and the main thread More explaination is in JIRA. Diffs ----- samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce6 samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java 209296d samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java 8948453 samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java 3e81240 Diff: https://reviews.apache.org/r/37428/diff/ Testing ------- Thanks, Yan Fang --===============6508240592247255656==--