Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 098E91819E for ; Thu, 6 Aug 2015 06:55:55 +0000 (UTC) Received: (qmail 42942 invoked by uid 500); 6 Aug 2015 06:55:54 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 42886 invoked by uid 500); 6 Aug 2015 06:55:54 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 42870 invoked by uid 99); 6 Aug 2015 06:55:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Aug 2015 06:55:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B41D01CC19C; Thu, 6 Aug 2015 06:55:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0757921581915699513==" MIME-Version: 1.0 Subject: Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code From: "Robert Zuljevic" To: Robert Zuljevic , =?utf-8?q?Gustavo_Anatoly_F=2E_V=2E_Sol=C3=ADs?= , samza , "Yi Pan \(Data Infrastructure\)" , Yan Fang Date: Thu, 06 Aug 2015 06:55:52 -0000 Message-ID: <20150806065552.11539.37764@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Zuljevic" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36163/ X-Sender: "Robert Zuljevic" References: <20150709143953.1573.93571@reviews.apache.org> In-Reply-To: <20150709143953.1573.93571@reviews.apache.org> Reply-To: "Robert Zuljevic" X-ReviewRequest-Repository: samza --===============0757921581915699513== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ ----------------------------------------------------------- (Updated Aug. 6, 2015, 6:55 a.m.) Review request for samza. Repository: samza Description (updated) ------- Implemented suggestions received in the review. Most changes are for sake of simplicity and clarity. Diffs (updated) ----- samza-api/src/main/java/org/apache/samza/system/SystemAdmin.java 7a588ebc99b5f07d533e48e10061a3075a63665a samza-api/src/main/java/org/apache/samza/util/SinglePartitionWithoutOffsetsSystemAdmin.java 249b8ae3a904716ea51a2b27c7701ac30d13b854 samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala f62161108f19ad29f40318331419438be5fb97b7 samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala c39cdc7ed86b591f379eda24005df25928bd8f16 samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 097f41062f3432ae9dc9a9737b48ed7b2f709f20 samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala 8d54c4639fc226b34e64915935c1d90e5917af2e samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala d9ae187c7707673fe15c8cb7ea854e02c4a89a54 samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemAdmin.java 1fd5dd34f70cb701b4c134b27464863d445b35f3 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 35086f54f526d5d88ad3bc312b71fce40260e7c6 samza-test/src/main/java/org/apache/samza/system/mock/MockSystemAdmin.java b063366f0f60e401765a000fa265c59dee4a461e samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 1e936b42a5b9a4bfb43766c17847b2947ebdb21d Diff: https://reviews.apache.org/r/36163/diff/ Testing ------- I wasn't really sure what kind of test (unit test / integration test) I should make here, so any pointers would be greatly appreaciated! I tested the change with the unit/integration tests already available. Thanks, Robert Zuljevic --===============0757921581915699513==--