Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95CCA180B8 for ; Tue, 4 Aug 2015 23:29:00 +0000 (UTC) Received: (qmail 84255 invoked by uid 500); 4 Aug 2015 23:28:55 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 84195 invoked by uid 500); 4 Aug 2015 23:28:55 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 84178 invoked by uid 99); 4 Aug 2015 23:28:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 23:28:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 483D8D944E; Tue, 4 Aug 2015 23:28:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4188385165424155292==" MIME-Version: 1.0 Subject: Re: Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown kafka consumer first From: "Yi Pan (Data Infrastructure)" To: "Yan Fang" , "samza" , "Yi Pan (Data Infrastructure)" Date: Tue, 04 Aug 2015 23:28:53 -0000 Message-ID: <20150804232853.17265.8041@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yi Pan (Data Infrastructure)" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37102/ X-Sender: "Yi Pan (Data Infrastructure)" References: <20150804230704.17265.40414@reviews.apache.org> In-Reply-To: <20150804230704.17265.40414@reviews.apache.org> Reply-To: "Yi Pan (Data Infrastructure)" X-ReviewRequest-Repository: samza --===============4188385165424155292== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37102/#review94146 ----------------------------------------------------------- Ship it! This makes sense! Thanks Yan! Did you verify with some test? It would be good to verify it. - Yi Pan (Data Infrastructure) On Aug. 4, 2015, 11:07 p.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37102/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 11:07 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-753 > https://issues.apache.org/jira/browse/SAMZA-753 > > > Repository: samza > > > Description > ------- > > shutdown the kafka consumer before interrupting the BrokerProxy > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f > > Diff: https://reviews.apache.org/r/37102/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > > --===============4188385165424155292==--