samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandar Bircakovic" <a.bircako...@levi9.com>
Subject Re: Review Request 37604: SAMZA-760 Samza Container should catch Throwables instead of just catching Exceptions
Date Tue, 25 Aug 2015 11:48:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37604/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 11:48 a.m.)


Review request for samza.


Changes
-------

Added a unit test for verification.


Repository: samza


Description
-------

Added a catch for Throwables in Samza container. Catching Throwables can cause problems in
specific situations so I also added a partial function 'safely' that should take care of that
specific situations.


Diffs (updated)
-----

  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 85b012b 
  samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 4db6d5c 

Diff: https://reviews.apache.org/r/37604/diff/


Testing
-------


Thanks,

Aleksandar Bircakovic


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message