samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information
Date Thu, 20 Aug 2015 20:55:16 GMT


> On Aug. 20, 2015, 5:36 p.m., Yan Fang wrote:
> > samza-core/src/main/java/org/apache/samza/container/ConfigManager.java, line 29
> > <https://reviews.apache.org/r/37536/diff/2/?file=1044899#file1044899line29>
> >
> >     How about renaming to LatestConfigManager? Then it is more specific and does
not confuse with other config related classes.

ConfigManager clashes with the ConfigManager in the auto-scaling sub-project. Can you actually
explain what is the purpose of this configmanager? You may want to reuse Shadi's code containing
ConfigManager.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37536/#review95965
-----------------------------------------------------------


On Aug. 20, 2015, 9:19 a.m., Aleksandar Bircakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37536/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:19 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> WebServlet and RestServlet now read information from coordinator stream consumer and
get new config.
> 
> 
> Diffs
> -----
> 
>   checkstyle/import-control.xml aaa235a 
>   samza-core/src/main/java/org/apache/samza/container/ConfigManager.java PRE-CREATION

>   samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
ca97ce8 
>   samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 7b59274 
>   samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce6

>   samza-core/src/test/scala/org/apache/samza/config/TestConfigManager.scala PRE-CREATION

>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
09f4dc3 
>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala
7fd5122 
> 
> Diff: https://reviews.apache.org/r/37536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Bircakovic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message