samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information
Date Thu, 20 Aug 2015 17:36:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37536/#review95965
-----------------------------------------------------------


can you also tested this patch? It does not start the LatestConfigManager anywhere, this may
cause problem. Thank you.


samza-core/src/main/java/org/apache/samza/container/ConfigManager.java (line 29)
<https://reviews.apache.org/r/37536/#comment151161>

    How about renaming to LatestConfigManager? Then it is more specific and does not confuse
with other config related classes.



samza-core/src/main/java/org/apache/samza/container/ConfigManager.java (line 33)
<https://reviews.apache.org/r/37536/#comment151159>

    the source should be "Job-coordinator"



samza-core/src/main/java/org/apache/samza/container/ConfigManager.java (line 42)
<https://reviews.apache.org/r/37536/#comment151160>

    copy/paste error . :)



samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
(line 100)
<https://reviews.apache.org/r/37536/#comment151157>

    if there is no other "manager" uses this method, maybe we can consider putting it into
the LatestConfigManager?



samza-core/src/test/scala/org/apache/samza/config/TestConfigManager.scala (line 34)
<https://reviews.apache.org/r/37536/#comment151155>

    wrong name.



samza-core/src/test/scala/org/apache/samza/config/TestConfigManager.scala (line 41)
<https://reviews.apache.org/r/37536/#comment151156>

    can this be a little more concrete? The thing we want to test is that, configManager gets
the current config, then we update the config, then we guarantee the configManager gets the
"latest" config?


- Yan Fang


On Aug. 20, 2015, 9:19 a.m., Aleksandar Bircakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37536/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:19 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> WebServlet and RestServlet now read information from coordinator stream consumer and
get new config.
> 
> 
> Diffs
> -----
> 
>   checkstyle/import-control.xml aaa235a 
>   samza-core/src/main/java/org/apache/samza/container/ConfigManager.java PRE-CREATION

>   samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
ca97ce8 
>   samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 7b59274 
>   samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce6

>   samza-core/src/test/scala/org/apache/samza/config/TestConfigManager.scala PRE-CREATION

>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
09f4dc3 
>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala
7fd5122 
> 
> Diff: https://reviews.apache.org/r/37536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Bircakovic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message