samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc
Date Thu, 20 Aug 2015 16:13:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37642/#review95964
-----------------------------------------------------------



docs/learn/documentation/versioned/jobs/logging.md (line 100)
<https://reviews.apache.org/r/37642/#comment151153>

    can it be something like "and change name of log stream with param 'StreamName'". Because
this is not the StreamAppender's name.



docs/learn/documentation/versioned/jobs/logging.md (line 104)
<https://reviews.apache.org/r/37642/#comment151154>

    how about adding a comment  "<!-- optional -->" here?


- Yan Fang


On Aug. 20, 2015, 9:25 a.m., Aleksandar Pejakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37642/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:25 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added requested param to logging.md
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/logging.md d1b372c 
> 
> Diff: https://reviews.apache.org/r/37642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Pejakovic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message