samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandar Bircakovic" <a.bircako...@levi9.com>
Subject Re: Review Request 37536: SAMZA-710 Update WebServlet and RestServlet to read coordinatorStream information
Date Thu, 20 Aug 2015 09:19:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37536/
-----------------------------------------------------------

(Updated Aug. 20, 2015, 9:19 a.m.)


Review request for samza.


Changes
-------

As the AbstractCoordinatorStreamManager is used to access and modify the coordinatorStreamConsumer
I kept method getLatestConfig there but I added a new class ConfigManager that is used to
provide the latest config instead of LocalityManager to avoid 'overuse'. Here is a simple
unit test that checks if getLatestConfig returns notNull. I also sanitized configMap as it
was mentioned. If this is a wrong way of thinking any suggestions will be appreciated. Thanks.


Repository: samza


Description
-------

WebServlet and RestServlet now read information from coordinator stream consumer and get new
config.


Diffs (updated)
-----

  checkstyle/import-control.xml aaa235a 
  samza-core/src/main/java/org/apache/samza/container/ConfigManager.java PRE-CREATION 
  samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java
ca97ce8 
  samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 7b59274 
  samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce6 
  samza-core/src/test/scala/org/apache/samza/config/TestConfigManager.scala PRE-CREATION 
  samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3

  samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala 7fd5122


Diff: https://reviews.apache.org/r/37536/diff/


Testing
-------


Thanks,

Aleksandar Bircakovic


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message