samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 37528: SAMZA-736 BrokerProxy will stuck in infinite loop if consumer.fetch throws OOME
Date Wed, 19 Aug 2015 05:05:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37528/#review95817
-----------------------------------------------------------



samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala (lines 163 - 164)
<https://reviews.apache.org/r/37528/#comment150958>

    will this stop the Container, or just log the error and finish this thread?
    
    If we want to stop the Container, I think we need to throw a SamzaException here.



samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala (line 46)
<https://reviews.apache.org/r/37528/#comment150960>

    why is the order changed?



samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala (line 366)
<https://reviews.apache.org/r/37528/#comment150959>

    this test seems not testing anything. :)


- Yan Fang


On Aug. 18, 2015, 12:58 p.m., Aleksandar Pejakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37528/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 12:58 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added new catch blocks to prevent infinite loops
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 376b277

>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f

>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec

> 
> Diff: https://reviews.apache.org/r/37528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Pejakovic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message