samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Milinda Pathirage" <mili...@apache.org>
Subject Re: Review Request 37506: WIP: SAMZA-552 Operator API change: New Builder API
Date Sun, 16 Aug 2015 15:56:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37506/
-----------------------------------------------------------

(Updated Aug. 16, 2015, 3:56 p.m.)


Review request for samza, Yi Pan (Data Infrastructure) and Navina Ramesh.


Bugs: SAMZA-552
    https://issues.apache.org/jira/browse/SAMZA-552


Repository: samza


Description
-------

New proposal for TopologuBuilder API proposed in rb34500 (https://reviews.apache.org/r/34500/).

* Created a new class called TopologyBuilderV2 instead of changing existing TopologyBuilder
* org.apache.samza.sql.operators.factory.TestTopologyBuilderV2 contains two tests which demonstrate
the basic usage of the new API
* Window and aggregate related draft APIs are not done yet
* This is a WIP, please feel free to comment on the APIs


Diffs (updated)
-----

  samza-sql-core/src/main/java/org/apache/samza/sql/api/data/EntityName.java 80ba455 
  samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Schema.java 1e8f192 
  samza-sql-core/src/main/java/org/apache/samza/sql/api/data/Table.java 7b4d984 
  samza-sql-core/src/main/java/org/apache/samza/sql/api/expressions/ScalarExpression.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/api/expressions/TupleExpression.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/Operator.java d6f6b57 
  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java fb2aa89

  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorRouter.java 0759638

  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorSink.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorSource.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java c49a822

  samza-sql-core/src/main/java/org/apache/samza/sql/data/IncomingMessageTuple.java 72a59f2

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/NoopOperatorCallback.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/OperatorTopology.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/SimpleOperatorImpl.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/SimpleOperatorSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/SimpleRouter.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/NoopOperatorCallback.java
c3d2266 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorFactoryImpl.java
cbc84d0 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java
e66451f 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorSpec.java
56753b6 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleRouter.java e570897

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/TopologyBuilder.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/TopologyBuilderException.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/TopologyBuilderV2.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/filter/FilterOp.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/filter/FilterSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/JoinSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/JoinType.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamRelationJoin.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java 2854aeb

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoinSpec.java
cc0aca0 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/modify/InsertToStreamOp.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/modify/Operation.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/modify/StreamModifySpec.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/modify/TableModifySpec.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/FieldBasedPartitionKeyGenerator.java
PRE-CREATION 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java b93d789

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionSpec.java
c47eed9 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/project/ProjectOp.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/project/ProjectSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/scan/StreamScan.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/scan/StreamScanSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/scan/TableScan.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/scan/TableScanSpec.java PRE-CREATION

  samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java
d81cc93 
  samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/WindowSpec.java eec32ea

  samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java b29838a

  samza-sql-core/src/test/java/org/apache/samza/sql/operators/factory/TestTopologyBuilderV2.java
PRE-CREATION 
  samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java 20dc701

  samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java 9124e3c 
  samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java 96e96c3


Diff: https://reviews.apache.org/r/37506/diff/


Testing
-------

./gradlew :samza-sql-core:test passed


Thanks,

Milinda Pathirage


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message