samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown kafka consumer first
Date Thu, 13 Aug 2015 01:12:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37102/
-----------------------------------------------------------

(Updated Aug. 13, 2015, 1:12 a.m.)


Review request for samza.


Changes
-------

added unit test for the closing.


Bugs: SAMZA-753
    https://issues.apache.org/jira/browse/SAMZA-753


Repository: samza


Description
-------

shutdown the kafka consumer before interrupting the BrokerProxy


Diffs (updated)
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e285dec 

Diff: https://reviews.apache.org/r/37102/diff/


Testing
-------


Thanks,

Yan Fang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message