samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>
Subject Re: Review Request 37102: SAMZA-753: BrokerProxy stop should shutdown kafka consumer first
Date Tue, 04 Aug 2015 23:28:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37102/#review94146
-----------------------------------------------------------

Ship it!


This makes sense! Thanks Yan! Did you verify with some test? It would be good to verify it.

- Yi Pan (Data Infrastructure)


On Aug. 4, 2015, 11:07 p.m., Yan Fang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37102/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 11:07 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-753
>     https://issues.apache.org/jira/browse/SAMZA-753
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> shutdown the kafka consumer before interrupting the BrokerProxy
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 614f33f

> 
> Diff: https://reviews.apache.org/r/37102/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yan Fang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message