Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09DBC181AF for ; Fri, 26 Jun 2015 00:20:01 +0000 (UTC) Received: (qmail 29076 invoked by uid 500); 26 Jun 2015 00:20:00 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 29012 invoked by uid 500); 26 Jun 2015 00:20:00 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 28979 invoked by uid 99); 26 Jun 2015 00:20:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2015 00:20:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8CD7DAAFDA; Fri, 26 Jun 2015 00:19:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4572613634263127430==" MIME-Version: 1.0 Subject: Re: Review Request 35492: SAMZA-701 : Hello Samza - Port docker setup from hadoop-common From: "Yan Fang" To: "Yan Fang" , "Darrell Taylor" , "samza" Date: Fri, 26 Jun 2015 00:19:59 -0000 Message-ID: <20150626001959.20383.89669@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yan Fang" X-ReviewGroup: Samza X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35492/ X-Sender: "Yan Fang" References: <20150616073600.1512.88640@reviews.apache.org> In-Reply-To: <20150616073600.1512.88640@reviews.apache.org> Reply-To: "Yan Fang" X-ReviewRequest-Repository: samza-hello-samza --===============4572613634263127430== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35492/#review89451 ----------------------------------------------------------- README.md (line 9) prefer to set use the name "start-docker-env.sh" to make it more speicific. dev-support/docker/Dockerfile (line 29) single line apt-get is not recommended. From https://docs.docker.com/articles/dockerfile_best-practices/ : "Don’t do RUN apt-get update on a single line. This will cause caching issues if the referenced archive gets updated, which will make your subsequent apt-get install fail without comment." - Yan Fang On June 16, 2015, 7:36 a.m., Darrell Taylor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35492/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 7:36 a.m.) > > > Review request for samza. > > > Repository: samza-hello-samza > > > Description > ------- > > Take the really useful docker setup from avro and hadoop-common and make it work for hello samza > > > Diffs > ----- > > README.md 4463454 > conf/yarn-site.xml 9028590 > dev-support/docker/Dockerfile PRE-CREATION > dev-support/docker/hadoop_env_checks.sh PRE-CREATION > start-env.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/35492/diff/ > > > Testing > ------- > > * Run ./start-env.sh from the top level directory > * Followed the instructions from "Start a Grid" on thsi page : http://samza.apache.org/startup/hello-samza/0.8/ > > > Thanks, > > Darrell Taylor > > --===============4572613634263127430==--