samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Fang" <yanfang...@gmail.com>
Subject Re: Review Request 35492: SAMZA-701 : Hello Samza - Port docker setup from hadoop-common
Date Fri, 26 Jun 2015 00:19:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35492/#review89451
-----------------------------------------------------------



README.md (line 9)
<https://reviews.apache.org/r/35492/#comment142082>

    prefer to set use the name "start-docker-env.sh" to make it more speicific.



dev-support/docker/Dockerfile (line 29)
<https://reviews.apache.org/r/35492/#comment142083>

    single line apt-get is not recommended. 
    
    From https://docs.docker.com/articles/dockerfile_best-practices/ : "Don’t do RUN apt-get
update on a single line. This will cause caching issues if the referenced archive gets updated,
which will make your subsequent apt-get install fail without comment."


- Yan Fang


On June 16, 2015, 7:36 a.m., Darrell Taylor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35492/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 7:36 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Take the really useful docker setup from avro and hadoop-common and make it work for
hello samza
> 
> 
> Diffs
> -----
> 
>   README.md 4463454 
>   conf/yarn-site.xml 9028590 
>   dev-support/docker/Dockerfile PRE-CREATION 
>   dev-support/docker/hadoop_env_checks.sh PRE-CREATION 
>   start-env.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35492/diff/
> 
> 
> Testing
> -------
> 
> * Run ./start-env.sh from the top level directory
> * Followed the instructions from "Start a Grid" on thsi page : http://samza.apache.org/startup/hello-samza/0.8/
> 
> 
> Thanks,
> 
> Darrell Taylor
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message