samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navina Ramesh" <nram...@linkedin.com>
Subject Re: Review Request 35067: SAMZA-546: Add config option max.in.flight.requests.per.connection
Date Mon, 08 Jun 2015 02:29:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35067/#review86980
-----------------------------------------------------------


Apart from the comments, lgtm!


samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala
<https://reviews.apache.org/r/35067/#comment139190>

    This warning is valid only when the configured value for max.in.flight.requests.per.connection
> 1. Can you check the value and make the comment more elaborate?



samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala
<https://reviews.apache.org/r/35067/#comment139191>

    We need a log message when this value is overriden (to < INT.MAX) and that Samza cannot
handle producer failures. Hence, the onus of retries is left up to the kafka producer.


- Navina Ramesh


On June 4, 2015, 1:50 p.m., Robert Zuljevic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35067/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 1:50 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added config max.in.flight.requests.per.connection and retries options for Kafka producers.
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala a1de88781a8ff2a3fe50389ae7a59062289404fc

> 
> Diff: https://reviews.apache.org/r/35067/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Robert Zuljevic
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message