samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luis De Pombo" <lfdepo...@gmail.com>
Subject Re: Review Request 34564: SAMZA-401: add utilization metrics for the event loop
Date Wed, 03 Jun 2015 16:48:12 GMT


> On May 22, 2015, 7:36 a.m., Yan Fang wrote:
> > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala,
line 41
> > <https://reviews.apache.org/r/34564/diff/1/?file=967023#file967023line41>
> >
> >     do we want to create a new Gauge every loop? I think one Gauge is sufficient,
we can update its value. What do you think?

Agreed


> On May 22, 2015, 7:36 a.m., Yan Fang wrote:
> > samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala, line 103
> > <https://reviews.apache.org/r/34564/diff/1/?file=967022#file967022line103>
> >
> >     can we nest the code as it is? It looks cleaner.
> >     
> >     I think like updateTimer, a similar method which returns the elapsed time, or
a method that accepts and updates the activeMs inside the method.

Agreed, a similar method that returns the elapsed time seems cleanest.


- Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34564/#review84886
-----------------------------------------------------------


On May 21, 2015, 8:53 p.m., Luis De Pombo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34564/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:53 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-401: add utilization metrics for the event loop
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala 4c0faf61c591771a05f233f311d7eb4524ac01ff

>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 7d9ff0040ff75a49e21d26d28d8940e5328fb2c5

>   samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 73ec2b5a7c1ca17fbb80604355881bff51f7e41e

> 
> Diff: https://reviews.apache.org/r/34564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis De Pombo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message