Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4534917C9F for ; Wed, 22 Apr 2015 15:12:32 +0000 (UTC) Received: (qmail 31619 invoked by uid 500); 22 Apr 2015 15:12:32 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 31561 invoked by uid 500); 22 Apr 2015 15:12:32 -0000 Mailing-List: contact dev-help@samza.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.apache.org Delivered-To: mailing list dev@samza.apache.org Received: (qmail 31546 invoked by uid 99); 22 Apr 2015 15:12:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 15:12:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 347C11D9C0F; Wed, 22 Apr 2015 15:12:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3865767972260874453==" MIME-Version: 1.0 Subject: Re: Review Request 33305: [SAMZA-655] Add EnvironmentConfigRewriter to samza-api. From: "Dan Harvey" To: "Navina Ramesh" , "Dan Harvey" , "samza" Date: Wed, 22 Apr 2015 15:12:33 -0000 Message-ID: <20150422151233.2948.23691@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dan Harvey" X-ReviewGroup: Samza X-ReviewRequest-URL: https://reviews.apache.org/r/33305/ X-Sender: "Dan Harvey" References: <20150420215517.2948.80395@reviews.apache.org> In-Reply-To: <20150420215517.2948.80395@reviews.apache.org> Reply-To: "Dan Harvey" X-ReviewRequest-Repository: samza --===============3865767972260874453== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 20, 2015, 9:55 p.m., Navina Ramesh wrote: > > Can you update the Samza [configuration docs](http://samza.apache.org/learn/documentation/latest/jobs/configuration-table.html) with info about this re-writer ? Sure, I've added to the configuration-table for this. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33305/#review80843 ----------------------------------------------------------- On April 22, 2015, 3:11 p.m., Dan Harvey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33305/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 3:11 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > [SAMZA-655] Add EnvironmentConfigRewriter to samza-api. > > > Diffs > ----- > > docs/learn/documentation/versioned/jobs/configuration-table.html 5ebe8a77bc3284de43268655897df33c003d56d6 > samza-core/src/main/java/org/apache/samza/config/EnvironmentConfigRewriter.java PRE-CREATION > samza-core/src/test/java/org/apache/samza/config/EnvironmentConfigRewriterTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/33305/diff/ > > > Testing > ------- > > > Thanks, > > Dan Harvey > > --===============3865767972260874453==--