samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ken Gidley" <kgid...@yahoo.com>
Subject Re: Review Request 33503: SAMZA-604 - Add support for using gradle to build/run hello-samza tasks.
Date Fri, 24 Apr 2015 19:47:09 GMT


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > README-gradle.txt, line 10
> > <https://reviews.apache.org/r/33503/diff/1/?file=940785#file940785line10>
> >
> >     "build hello-samza job package" sounds better because actually "./gradlw build"
is for "build hello-samza project", not "distTar".

ok, fixed.


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > README-gradle.txt, line 18
> > <https://reviews.apache.org/r/33503/diff/1/?file=940785#file940785line18>
> >
> >     start grid sounds better

fixed


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > build.gradle, line 97
> > <https://reviews.apache.org/r/33503/diff/1/?file=940786#file940786line97>
> >
> >     can we use installGrid ?

ok, done.


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > build.gradle, line 108
> > <https://reviews.apache.org/r/33503/diff/1/?file=940786#file940786line108>
> >
> >     use installSamza or deploySamza ?

changed to: deployHelloSamza


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > build.gradle, line 115
> > <https://reviews.apache.org/r/33503/diff/1/?file=940786#file940786line115>
> >
> >     can we use startGrid here to be consistent with "stopGrid" ?

done


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > build.gradle, line 172
> > <https://reviews.apache.org/r/33503/diff/1/?file=940786#file940786line172>
> >
> >     name to listKafkaTopics?

done


> On April 24, 2015, 6:54 p.m., Yan Fang wrote:
> > gradle/wrapper/gradle-wrapper.properties, line 6
> > <https://reviews.apache.org/r/33503/diff/1/?file=940789#file940789line6>
> >
> >     downloading binary is sufficient, which is smaller in terms of the size.

ok, will change.  I prefer the 'all' package for debugging, etc.


- Ken


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33503/#review81506
-----------------------------------------------------------


On April 24, 2015, 2:40 a.m., Ken Gidley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33503/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 2:40 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Create build.gradle, gradle.properties, and README-gradle.txt files for hello-samza.
> Update pom.xml to exclude gradle related files and build artifacts from RAT license
> checks when using Maven.
> 
> Update to 0.9.0 Samza, 0.8.2.1 Kafka
> 
> Rebase to latest ‘hello-samza’, with 0.9.0 Samza and 0.8.2.1 Kafka.
> Remove unneeded dependency on old serializers.
> 
> 
> Diffs
> -----
> 
>   .gitignore 0435c14b334fef6a7dd0e401195e9cce88f60a4a 
>   README-gradle.txt PRE-CREATION 
>   build.gradle PRE-CREATION 
>   gradle.properties PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.jar PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties PRE-CREATION 
>   gradlew PRE-CREATION 
>   gradlew.bat PRE-CREATION 
>   pom.xml b4ea5613e520fa94f635426a469d496c69efc9ac 
> 
> Diff: https://reviews.apache.org/r/33503/diff/
> 
> 
> Testing
> -------
> 
> Local build/testing done on Mac, with Java 1.7.
> 
> 
> Thanks,
> 
> Ken Gidley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message