samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Fradet" <benjamin.fra...@gmail.com>
Subject Re: Review Request 33409: SAMZA-433 - Rename "task" to "container" in AM and container
Date Fri, 24 Apr 2015 12:53:51 GMT


> On April 24, 2015, 12:58 a.m., Yan Fang wrote:
> > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml, lines 131-135
> > <https://reviews.apache.org/r/33409/diff/1/?file=938743#file938743line131>
> >
> >     This one was correct. Only need to change the state.runningTasks to state.runningContainers.
> >     
> >     (It's really confusing...*_*)
> >     
> >     The idea is that, one container can have multiple task(name)s. One container
is though as "one task group" Task (group) Id is equal to "ContainerId" in Yarn's context.

Thanks a lot for this explanation, I had some serious doubts about this one.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33409/#review81436
-----------------------------------------------------------


On April 21, 2015, 8:57 p.m., Benjamin Fradet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33409/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 8:57 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Renamed a few variables so the code is consistent and logic with naming scheme used in
Samza
> 
> 
> Diffs
> -----
> 
>   samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2b1aa3e 
>   samza-yarn/src/main/scala/org/apache/samza/config/YarnConfig.scala 03395e2 
>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala ee2aa32

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala 8ba435e

>   samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala
b0b6543 
>   samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala
4c855bf 
>   samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala
58f2464 
> 
> Diff: https://reviews.apache.org/r/33409/diff/
> 
> 
> Testing
> -------
> 
> Tested the `samza-yarn` submodule since it is the only one impacted
> 
> 
> Thanks,
> 
> Benjamin Fradet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message