Return-Path: X-Original-To: apmail-samza-dev-archive@minotaur.apache.org Delivered-To: apmail-samza-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 118D11055D for ; Mon, 24 Nov 2014 18:29:05 +0000 (UTC) Received: (qmail 49792 invoked by uid 500); 24 Nov 2014 18:29:05 -0000 Delivered-To: apmail-samza-dev-archive@samza.apache.org Received: (qmail 49744 invoked by uid 500); 24 Nov 2014 18:29:04 -0000 Mailing-List: contact dev-help@samza.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@samza.incubator.apache.org Delivered-To: mailing list dev@samza.incubator.apache.org Received: (qmail 49733 invoked by uid 99); 24 Nov 2014 18:29:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 18:29:04 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 24 Nov 2014 18:29:03 +0000 Received: (qmail 49508 invoked by uid 99); 24 Nov 2014 18:28:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 18:28:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 29C9369B65; Mon, 24 Nov 2014 18:28:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4920934175081947302==" MIME-Version: 1.0 Subject: Re: Review Request 28035: SAMZA-310-1 From: "Chris Riccomini" To: "Yan Fang" , "samza" , "Chris Riccomini" Date: Mon, 24 Nov 2014 18:28:42 -0000 Message-ID: <20141124182842.15977.6368@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Riccomini" X-ReviewGroup: Samza X-ReviewRequest-URL: https://reviews.apache.org/r/28035/ X-Sender: "Chris Riccomini" References: <20141124091614.15977.45965@reviews.apache.org> In-Reply-To: <20141124091614.15977.45965@reviews.apache.org> Reply-To: "Chris Riccomini" X-ReviewRequest-Repository: samza X-Virus-Checked: Checked by ClamAV on apache.org --===============4920934175081947302== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28035/#review62826 ----------------------------------------------------------- Overall, looks very good to me. Some minor code nits. I haven't run the code in a real grid, though. docs/learn/documentation/versioned/jobs/logging.md No newline needed between "use" and "this". add: (add colon) docs/learn/documentation/versioned/jobs/logging.md add: (colon) samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java StreamAppender. samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java We will need to make this a little more pluggable, so that systems can use different serializers for LoggingEvent (this one forces strings), but we can save that for a separate ticket. samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java assert job name not null or throw exception. - Chris Riccomini On Nov. 24, 2014, 9:16 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28035/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 9:16 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-310 > https://issues.apache.org/jira/browse/SAMZA-310 > > > Repository: samza > > > Description > ------- > > Added a log4j appender using SystemProducer > Added a log4jConfig class to help get log4j specific config > Unit test code > > > Diffs > ----- > > build.gradle 828bce9 > docs/learn/documentation/versioned/jobs/configuration-table.html fbb5ea4 > docs/learn/documentation/versioned/jobs/logging.md 58e56c1 > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java PRE-CREATION > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java PRE-CREATION > samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java PRE-CREATION > samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemFactory.java PRE-CREATION > samza-log4j/src/test/java/org/apache/samza/logging/log4j/MockSystemProducer.java PRE-CREATION > samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java PRE-CREATION > > Diff: https://reviews.apache.org/r/28035/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > > --===============4920934175081947302==--